Build and test using GitHub actions workflow #2505
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the Windows build is failing on a single test. The reason for the failure appears to be related to the log2 function incorrectly calculating results. It's not yet clear how to proceed with the faulty log2 implementation.
The primary reason for the update is to fix the build on MacOS. During the build it was receiving this error: posix.c:94:3: error: implicit declaration of function 'onig_end' is invalid in C99 [-Werror,-Wimplicit-function-declaration] onig_end(); This was later fixed in the oniguruma repo on this commit: kkos/oniguruma@5a24a49
|
Hey, about CI i know @nicowilliams has been looking into adding at https://github.com/jqlang/jq Oniguruma update looks resonable to me. Would it make sense to update to latest? 6.9.8? The pow/log2 issue for cygwin i don't know much about. Could it be some float as string representation issue? how does it handle |
|
Re: log2: You've probably gotten this far already, but here are a few links just in case it's helpful. Looks like others have encountered this issue before:
|
|
We have switched to GitHub Actions in #2596, so closing this PR. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update to oniguruma 6.7.1 to fix the build on MacOS.