-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deb package #2226
base: master
Are you sure you want to change the base?
Update deb package #2226
Conversation
After merging master in the branch, when im running |
This is because each binary variant requires different features:
Can we have multiple cargo-deb sections for each? |
I will need to test it |
Include all the debin packages in release
assets = [["target/release/qsv", "/usr/local/bin/", "755"]] | ||
|
||
# Default feature and asset | ||
features = ["feature_capable"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to add the features you actually want to enable. Otherwise, this is just like qsvlite.
I suggest to add everything EXCEPT python, as doing so creates a runtime dependency on the specific version of python libraries being present at startup, even if you're not using the py
command:
["feature_capable","apply","fetch","foreach","geocode","lens","luau","polars","prompt","to"]
You can also enable the python
feature if you can specify cargo-deb to have a dependency on the specific version of python you need to be installed in the config.
We will include qsv, qsvdp, qsvlite in the deb package