Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deb package #2226

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

tino097
Copy link
Collaborator

@tino097 tino097 commented Oct 21, 2024

We will include qsv, qsvdp, qsvlite in the deb package

@tino097 tino097 marked this pull request as draft October 21, 2024 08:15
@tino097
Copy link
Collaborator Author

tino097 commented Oct 21, 2024

   --> src/cmd/sortcheck.rs:115:9
    |
115 |         record_count = if show_progress {
    |         ^^^^^^^^^^^^
    |
    = help: maybe it is overwritten before being read?
    = note: `#[warn(unused_assignments)]` on by default

error[E0384]: cannot assign twice to immutable variable `record_count`
   --> src/cmd/sortcheck.rs:126:9
    |
115 | /         record_count = if show_progress {
116 | |             let count = util::count_rows(&rconfig)?;
117 | |             util::prep_progress(&progress, count);
118 | |             count
...   |
121 | |             0
122 | |         };
    | |_________- first assignment to `record_count`
...
126 |           record_count = 0;
    |           ^^^^^^^^^^^^^^^^ cannot assign twice to immutable variable
    |
help: consider making this binding mutable
    |
105 |     let mut record_count;
    |         +++

For more information about this error, try `rustc --explain E0384`.
warning: `qsv` (bin "qsv") generated 1 warning
error: could not compile `qsv` (bin "qsv") due to 1 previous error; 1 warning emitted
cargo-deb: build failed

After merging master in the branch, when im running cargo deb im getting this error

@jqnatividad
Copy link
Owner

This is because each binary variant requires different features:

  • qsv - all_features
  • qsvlite - lite
  • qsvdp - datapusher_plus, luau

Can we have multiple cargo-deb sections for each?

@tino097
Copy link
Collaborator Author

tino097 commented Oct 21, 2024

I will need to test it

@tino097 tino097 marked this pull request as ready for review October 21, 2024 20:34
assets = [["target/release/qsv", "/usr/local/bin/", "755"]]

# Default feature and asset
features = ["feature_capable"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to add the features you actually want to enable. Otherwise, this is just like qsvlite.
I suggest to add everything EXCEPT python, as doing so creates a runtime dependency on the specific version of python libraries being present at startup, even if you're not using the py command:

["feature_capable","apply","fetch","foreach","geocode","lens","luau","polars","prompt","to"]

You can also enable the python feature if you can specify cargo-deb to have a dependency on the specific version of python you need to be installed in the config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants