Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

withPrefabValues can generate illegal reflective access warnings #215

Closed
jqno opened this issue Oct 23, 2018 · 1 comment
Closed

withPrefabValues can generate illegal reflective access warnings #215

jqno opened this issue Oct 23, 2018 · 1 comment
Labels
accepted

Comments

@jqno
Copy link
Owner

jqno commented Oct 23, 2018

As discovered in #214, withPrefabValues can generate illegal reflective access warnings if used on a type that is defined in a different module that isn't open for reflection. This happens when EqualsVerifier tries to clone the red value into the redCopy value.

This should be fixed. If that's not possible, there should be a workaround (for instance, by adding an overloaded withPrefabValues method with a redCopy parameter.
@jqno jqno assigned jqno and unassigned jqno Oct 23, 2018
@jqno jqno added the accepted label Oct 23, 2018
@jqno jqno mentioned this issue Oct 23, 2018
Closed
jqno added a commit that referenced this issue Dec 24, 2018
@jqno
#215: withPrefabValues can generate illegal reflective access warnings
e9ff896
jqno added a commit that referenced this issue Dec 24, 2018
@jqno
#206 turns out to be a duplicate of #215
4615493
@jqno
Copy link
Owner Author

jqno commented Dec 24, 2018

It's fixed in version 3.1. You'll still get the illegal reflective access warnings if you run without --illegal-access=deny, which is unfortunate, but there will be no InaccessibleObjectException when you run with it.

@jqno jqno closed this as completed Dec 24, 2018
akhalikov pushed a commit to akhalikov/equalsverifier that referenced this issue Nov 6, 2019
@jqno
jqno#215: withPrefabValues can generate illegal reflective access war…
f828049 
…nings
akhalikov pushed a commit to akhalikov/equalsverifier that referenced this issue Nov 6, 2019
@jqno
jqno#206 turns out to be a duplicate of jqno#215
87e5dce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jqno