Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ttt.py #248

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Update ttt.py #248

merged 1 commit into from
Oct 8, 2024

Conversation

jquagga
Copy link
Owner

@jquagga jquagga commented Oct 8, 2024

Summary by Sourcery

Modify the transcription function to include timestamps in the output by updating the 'return_timestamps' parameter to True.

Enhancements:

  • Enable the return of timestamps in the transcription results by setting 'return_timestamps' to True.

Copy link
Contributor

sourcery-ai bot commented Oct 8, 2024

Reviewer's Guide by Sourcery

This pull request updates the transcribe_transformers function in the ttt.py file to enable timestamp generation in the transcription process.

Sequence diagram for the updated transcription process

sequenceDiagram
    participant User
    participant System
    participant PIPE
    User->>System: Provide audiofile
    System->>PIPE: Call PIPE with audiofile and generate_kwargs {"language": "english", "return_timestamps": True}
    PIPE-->>System: Return transcription with timestamps
    System-->>User: Return calljson with text and timestamps
Loading

File-Level Changes

Change Details Files
Enable timestamp generation in the transcription process
  • Changed the return_timestamps parameter from False to True in the PIPE function call
ttt.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@jquagga jquagga enabled auto-merge (squash) October 8, 2024 20:33
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jquagga - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a brief inline comment explaining why timestamps are now being returned. This will help future maintainers understand the intention behind this change.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

ttt.py Show resolved Hide resolved
@jquagga jquagga merged commit 5e66f00 into main Oct 8, 2024
4 checks passed
@jquagga jquagga deleted the jquagga-patch-3 branch October 12, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant