Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Pylint fixes #268

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Additional Pylint fixes #268

merged 3 commits into from
Apr 5, 2024

Conversation

avylove
Copy link
Collaborator

@avylove avylove commented Apr 3, 2024

Hopefully this takes care of the rest of the issues.

  • Added type hints for _time_left(), _read_until, and DEFAULT_ESCDELAY in keyboard.pyi
  • Removed functools.partial() in Terminal.inkey()
    • Pylint complained about no return value
    • It doesn't seem necessary anymore. I think at one point it consolidated some complicated code, but now these calls are pretty simple
  • Ignore two cases where Pylint reported a false positive

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.41%. Comparing base (e904de3) to head (f7b3651).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
- Coverage   95.42%   95.41%   -0.01%     
==========================================
  Files           9        9              
  Lines        1027     1025       -2     
  Branches      216      216              
==========================================
- Hits          980      978       -2     
  Misses         43       43              
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@jquast jquast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jquast jquast merged commit 75a34ef into master Apr 5, 2024
25 checks passed
@jquast jquast deleted the pytlint_pyi_2 branch April 5, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants