Python 3.7 compatibilty #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Trying to give this attention today, dropping py3.4 is fine, this looks great, thanks. I'll try to push soon |
jquast
force-pushed
the
python37-compat
branch
from
5befa2b to
487f896
Compare
|
this is release to pypi as well now, thanks so much for the help, i'm extra-full-time employed and unable to maintain this project so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This pull request fixes telnetlib3 to work with python 3.7 by removing references to the deprecated
asyncio.asyncvariable.I also found the tests didn't run under 3.7 but updating them to use
async/awaitsyntax fixes this. This is a breaking change if you still wish to support older versions of python so I could re-submit this as a separate pull request if required?Regards,
Andrew.