-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for EOL Python 2.7 and 3.5 #117
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #117 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 105 96 -9
Branches 25 23 -2
=========================================
- Hits 105 96 -9 ☔ View full report in Codecov by Sentry. |
@jquast can we move forward with it? |
Hi, checking in one year later and resolved the conflict :) Looks like the Windows failures are caused by a GitHub bug: actions/setup-python#1034 Hopefully they'll fix it soon. |
@hugovk feel free to use my new action approach for this: aio-libs/frozenlist#622 + aio-libs/frozenlist#633. I'm planning to keep it alive because I've been wanting a better cache control anyway. https://github.com/marketplace/actions/cache-python-deps |
Thanks, we're not in a rush with this PR, because we're still pending #120 and a release before looking at this one, so I think we can wait a bit longer. |
@hugovk fair! I just saw your back reference and realized I forgot to post about it over on the GH tracker. Did that just now. |
Fixes #102.