New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support for empty path #9

Closed

vonagam wants to merge 1 commit into jquense:master from vonagam:empty-path

vonagam commented Feb 3, 2019

No description provided.


          Fix support for empty path

c62c75e

vonagam mentioned this pull request

feat: support self references jquense/yup#443

Merged

jquense pushed a commit to jquense/yup that referenced this pull request


          feat: support self references (#443)

1cac515

`key` cannot be a function since [`validateName`](https://github.com/jquense/yup/blob/d02ff5e59e004b4c5189d1b9fc0055cff45c61df/src/Reference.js#L3) ensures that it is a string.

`isSelf` is not used anywhere and `key="."` isn't supported by `property-expr` getter.

For working self references i opened [pull request](jquense/expr#9) in `property-expr` to support empty string path. (currently `getter("")` works, but `getter("", true)` which is used in Reference.js throws)

jquense closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet