Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove propTypes in production #1180

Merged
merged 1 commit into from
Jan 17, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .babelrc
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
{
"presets": ["jason"],
plugins: [
['transform-react-remove-prop-types', { mode: 'wrap' }],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason you prefer wrap vs remove and removeImport, the latter would save more bytes no?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't user validation one of the points of having prop types?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will save only 300b. So we may skip it for now

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah right, it'd be removed for the unminified build as well

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prop types are not removed. This project has two blockers mixing and old context api.

],
"env": {
"esm": {
"presets": [
Expand Down
12 changes: 6 additions & 6 deletions .size-snapshot.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
{
"./dist/react-big-calendar.js": {
"bundled": 470107,
"minified": 152579,
"gzipped": 42233
"bundled": 469894,
"minified": 152522,
"gzipped": 42174
},
"./dist/react-big-calendar.min.js": {
"bundled": 439313,
"minified": 142681,
"gzipped": 39554
"bundled": 412865,
"minified": 135555,
"gzipped": 38300
}
}
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@
"babel-core": "^7.0.0-bridge.0",
"babel-eslint": "^10.0.1",
"babel-jest": "^23.6.0",
"babel-plugin-transform-react-remove-prop-types": "^0.4.22",
"babel-preset-jason": "^6.0.1",
"bootstrap": "^3.3.5",
"component-metadata-loader": "^4.0.0",
Expand Down
34 changes: 17 additions & 17 deletions src/Agenda.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,23 +10,6 @@ import { inRange } from './utils/eventLevels'
import { isSelected } from './utils/selection'

class Agenda extends React.Component {
static propTypes = {
events: PropTypes.array,
date: PropTypes.instanceOf(Date),
length: PropTypes.number.isRequired,

selected: PropTypes.object,

accessors: PropTypes.object.isRequired,
components: PropTypes.object.isRequired,
getters: PropTypes.object.isRequired,
localizer: PropTypes.object.isRequired,
}

static defaultProps = {
length: 30,
}

componentDidMount() {
this._adjustHeader()
}
Expand Down Expand Up @@ -200,6 +183,23 @@ class Agenda extends React.Component {
}
}

Agenda.propTypes = {
events: PropTypes.array,
date: PropTypes.instanceOf(Date),
length: PropTypes.number.isRequired,

selected: PropTypes.object,

accessors: PropTypes.object.isRequired,
components: PropTypes.object.isRequired,
getters: PropTypes.object.isRequired,
localizer: PropTypes.object.isRequired,
}

Agenda.defaultProps = {
length: 30,
}

Agenda.range = (start, { length = Agenda.defaultProps.length }) => {
let end = dates.add(start, length, 'day')
return { start, end }
Expand Down
42 changes: 21 additions & 21 deletions src/BackgroundCells.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,27 +9,6 @@ import { dateCellSelection, getSlotAtX, pointInBox } from './utils/selection'
import Selection, { getBoundsForNode, isEvent } from './Selection'

class BackgroundCells extends React.Component {
static propTypes = {
date: PropTypes.instanceOf(Date),
getNow: PropTypes.func.isRequired,

getters: PropTypes.object.isRequired,
components: PropTypes.object.isRequired,

container: PropTypes.func,
dayPropGetter: PropTypes.func,
selectable: PropTypes.oneOf([true, false, 'ignoreEvents']),
longPressThreshold: PropTypes.number,

onSelectSlot: PropTypes.func.isRequired,
onSelectEnd: PropTypes.func,
onSelectStart: PropTypes.func,

range: PropTypes.arrayOf(PropTypes.instanceOf(Date)),
rtl: PropTypes.bool,
type: PropTypes.string,
}

constructor(props, context) {
super(props, context)

Expand Down Expand Up @@ -185,4 +164,25 @@ class BackgroundCells extends React.Component {
}
}

BackgroundCells.propTypes = {
date: PropTypes.instanceOf(Date),
getNow: PropTypes.func.isRequired,

getters: PropTypes.object.isRequired,
components: PropTypes.object.isRequired,

container: PropTypes.func,
dayPropGetter: PropTypes.func,
selectable: PropTypes.oneOf([true, false, 'ignoreEvents']),
longPressThreshold: PropTypes.number,

onSelectSlot: PropTypes.func.isRequired,
onSelectEnd: PropTypes.func,
onSelectStart: PropTypes.func,

range: PropTypes.arrayOf(PropTypes.instanceOf(Date)),
rtl: PropTypes.bool,
type: PropTypes.string,
}

export default BackgroundCells
6 changes: 5 additions & 1 deletion src/Calendar.js
Original file line number Diff line number Diff line change
Expand Up @@ -952,7 +952,11 @@ class Calendar extends React.Component {
}

let views = this.getViews()
this.handleRangeChange(this.props.date || this.props.getNow(), views[view], view)
this.handleRangeChange(
this.props.date || this.props.getNow(),
views[view],
view
)
}

handleSelectEvent = (...args) => {
Expand Down
81 changes: 39 additions & 42 deletions src/DateContentRow.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,46 +11,6 @@ import EventRow from './EventRow'
import EventEndingRow from './EventEndingRow'
import * as DateSlotMetrics from './utils/DateSlotMetrics'

const propTypes = {
date: PropTypes.instanceOf(Date),
events: PropTypes.array.isRequired,
range: PropTypes.array.isRequired,

rtl: PropTypes.bool,
resourceId: PropTypes.any,
renderForMeasure: PropTypes.bool,
renderHeader: PropTypes.func,

container: PropTypes.func,
selected: PropTypes.object,
selectable: PropTypes.oneOf([true, false, 'ignoreEvents']),
longPressThreshold: PropTypes.number,

onShowMore: PropTypes.func,
onSelectSlot: PropTypes.func,
onSelect: PropTypes.func,
onSelectEnd: PropTypes.func,
onSelectStart: PropTypes.func,
onDoubleClick: PropTypes.func,
dayPropGetter: PropTypes.func,

getNow: PropTypes.func.isRequired,
isAllDay: PropTypes.bool,

accessors: PropTypes.object.isRequired,
components: PropTypes.object.isRequired,
getters: PropTypes.object.isRequired,
localizer: PropTypes.object.isRequired,

minRows: PropTypes.number.isRequired,
maxRows: PropTypes.number.isRequired,
}

const defaultProps = {
minRows: 0,
maxRows: Infinity,
}

class DateContentRow extends React.Component {
constructor(...args) {
super(...args)
Expand Down Expand Up @@ -218,7 +178,44 @@ class DateContentRow extends React.Component {
}
}

DateContentRow.propTypes = propTypes
DateContentRow.defaultProps = defaultProps
DateContentRow.propTypes = {
date: PropTypes.instanceOf(Date),
events: PropTypes.array.isRequired,
range: PropTypes.array.isRequired,

rtl: PropTypes.bool,
resourceId: PropTypes.any,
renderForMeasure: PropTypes.bool,
renderHeader: PropTypes.func,

container: PropTypes.func,
selected: PropTypes.object,
selectable: PropTypes.oneOf([true, false, 'ignoreEvents']),
longPressThreshold: PropTypes.number,

onShowMore: PropTypes.func,
onSelectSlot: PropTypes.func,
onSelect: PropTypes.func,
onSelectEnd: PropTypes.func,
onSelectStart: PropTypes.func,
onDoubleClick: PropTypes.func,
dayPropGetter: PropTypes.func,

getNow: PropTypes.func.isRequired,
isAllDay: PropTypes.bool,

accessors: PropTypes.object.isRequired,
components: PropTypes.object.isRequired,
getters: PropTypes.object.isRequired,
localizer: PropTypes.object.isRequired,

minRows: PropTypes.number.isRequired,
maxRows: PropTypes.number.isRequired,
}

DateContentRow.defaultProps = {
minRows: 0,
maxRows: Infinity,
}

export default DateContentRow
8 changes: 4 additions & 4 deletions src/Day.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@ import { navigate } from './utils/constants'
import TimeGrid from './TimeGrid'

class Day extends React.Component {
static propTypes = {
date: PropTypes.instanceOf(Date).isRequired,
}

render() {
let { date, ...props } = this.props
let range = Day.range(date)
Expand All @@ -18,6 +14,10 @@ class Day extends React.Component {
}
}

Day.propTypes = {
date: PropTypes.instanceOf(Date).isRequired,
}

Day.range = date => {
return [dates.startOf(date, 'day')]
}
Expand Down
80 changes: 40 additions & 40 deletions src/DayColumn.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,46 +14,6 @@ import TimeSlotGroup from './TimeSlotGroup'
import TimeGridEvent from './TimeGridEvent'

class DayColumn extends React.Component {
static propTypes = {
events: PropTypes.array.isRequired,
step: PropTypes.number.isRequired,
date: PropTypes.instanceOf(Date).isRequired,
min: PropTypes.instanceOf(Date).isRequired,
max: PropTypes.instanceOf(Date).isRequired,
getNow: PropTypes.func.isRequired,
isNow: PropTypes.bool,

rtl: PropTypes.bool,

accessors: PropTypes.object.isRequired,
components: PropTypes.object.isRequired,
getters: PropTypes.object.isRequired,
localizer: PropTypes.object.isRequired,

showMultiDayTimes: PropTypes.bool,
culture: PropTypes.string,
timeslots: PropTypes.number,

selected: PropTypes.object,
selectable: PropTypes.oneOf([true, false, 'ignoreEvents']),
eventOffset: PropTypes.number,
longPressThreshold: PropTypes.number,

onSelecting: PropTypes.func,
onSelectSlot: PropTypes.func.isRequired,
onSelectEvent: PropTypes.func.isRequired,
onDoubleClickEvent: PropTypes.func.isRequired,

className: PropTypes.string,
dragThroughEvents: PropTypes.bool,
resource: PropTypes.any,
}

static defaultProps = {
dragThroughEvents: true,
timeslots: 2,
}

state = { selecting: false, timeIndicatorPosition: null }

constructor(...args) {
Expand Down Expand Up @@ -390,4 +350,44 @@ class DayColumn extends React.Component {
}
}

DayColumn.propTypes = {
events: PropTypes.array.isRequired,
step: PropTypes.number.isRequired,
date: PropTypes.instanceOf(Date).isRequired,
min: PropTypes.instanceOf(Date).isRequired,
max: PropTypes.instanceOf(Date).isRequired,
getNow: PropTypes.func.isRequired,
isNow: PropTypes.bool,

rtl: PropTypes.bool,

accessors: PropTypes.object.isRequired,
components: PropTypes.object.isRequired,
getters: PropTypes.object.isRequired,
localizer: PropTypes.object.isRequired,

showMultiDayTimes: PropTypes.bool,
culture: PropTypes.string,
timeslots: PropTypes.number,

selected: PropTypes.object,
selectable: PropTypes.oneOf([true, false, 'ignoreEvents']),
eventOffset: PropTypes.number,
longPressThreshold: PropTypes.number,

onSelecting: PropTypes.func,
onSelectSlot: PropTypes.func.isRequired,
onSelectEvent: PropTypes.func.isRequired,
onDoubleClickEvent: PropTypes.func.isRequired,

className: PropTypes.string,
dragThroughEvents: PropTypes.bool,
resource: PropTypes.any,
}

DayColumn.defaultProps = {
dragThroughEvents: true,
timeslots: 2,
}

export default DayColumn
Loading