Fix the Example page's title, and improve docs #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, I just noticed that this repo has a |
|
that would be great yeah 👍 |
Reference Yarn as the primary installer.
MatthewHerbst
changed the title
|
@jquense done! |
Because we use the `html-webpack-plugin` via `webpack-atoms`, the `index.html` file we had was not being used. This removes it, and it properly sets the page's document title using the options to the `html-webpack-plugin`.
|
@jquense this is ready for final review I believe when you get a chance, thank you! |
jquense
approved these changes
Mar 21, 2019
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
html-webpack-plugin(viawebpack-atoms) theindex.htmlfile that was here was not being usedtitleattribute to thehtml-webpack-plugin