-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1649 multiple resources #1724
1649 multiple resources #1724
Conversation
Is this something that will eventually be accepted? I used this feature in one of my projects and everything seems to work as expected. |
Hi! Is there anything further i can do to accept this feature? I would really appreciate to have this in the react big calendar |
This feature is now available in the master branch, so everything done. EDIT: not true, i was wrong! |
Is this actually in master? I don't see any of your changes in the master branch and the feature does not appear to be available. |
true! I was wrong! ... can someone merge it? |
@jquense Is there something else needed to be done to get this Pull Request reviewed or committed? |
Nice feature @georgebuciuman @mitsol It's possible for the conflicts to be solved Could I help with that? |
I corrected the error when resizing a multi-resource event. Should work now! |
Should work now as expected, please check. |
Just wondering if there are any updates on this? This is a really useful feature. |
Sorry guys, don't know why this won't be merged 🤷♂️ |
@mitsol Thanks for fixing the conflicts. @jquense @georgebuciuman Just wondering if there's any timeline we can expect for this to get merged in? Or anything else that needs to be done first? |
@mitsol The new docs site went live yesterday, and all examples were moved into storybook. If you can integrate changes from master, and move your examples into a story with documentation (plus any other documentation updates needed), I'll review everything for inclusion. |
I'm looking into reconciling @mitsol 's changes with these updates. May need a second pair of eyes on it though from someone more familiar with this package. Will link to the new PR once it's ready for review. |
@jimhlad thanks a lot! Unfortunately i'm very busy at the moment, but everything I changed in the code I have already stated here: So should not be a big deal to change! I recently had a look with the new storybook documentation, but it needs more effort for me to adapt my changes for this new documentation. |
Closing this PR in favor of #2165 |
According to #1649 I added the functionality to let events have multiple resources. The resourceId of an event can now also be an array of numbers, holding the related resourceIds.
I also modified the code to work with drag and drop for multi-resource events. There are 2 different modes:
Take a look in the
dndresource.js
example.Fixes #1649