Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1649 multiple resources #1724

Closed
wants to merge 18 commits into from
Closed

Conversation

mitsol
Copy link

@mitsol mitsol commented Aug 10, 2020

According to #1649 I added the functionality to let events have multiple resources. The resourceId of an event can now also be an array of numbers, holding the related resourceIds.

I also modified the code to work with drag and drop for multi-resource events. There are 2 different modes:

  1. CopyMode: By dragging an event into a different resource grid, the event gets assigned to both resourceIds
  2. MoveMode: By dragging an event into a different resource grid, the event gets deleted from the source resource and added to the target resource.

Take a look in the dndresource.js example.

Fixes #1649

@joejensen
Copy link

Is this something that will eventually be accepted? I used this feature in one of my projects and everything seems to work as expected.

@mitsol
Copy link
Author

mitsol commented Dec 13, 2020

Hi! Is there anything further i can do to accept this feature? I would really appreciate to have this in the react big calendar

@mitsol
Copy link
Author

mitsol commented Jan 16, 2021

This feature is now available in the master branch, so everything done.

EDIT: not true, i was wrong!

@mitsol mitsol closed this Jan 16, 2021
@Slogo
Copy link

Slogo commented Feb 23, 2021

Is this actually in master? I don't see any of your changes in the master branch and the feature does not appear to be available.

@mitsol
Copy link
Author

mitsol commented Feb 24, 2021

Is this actually in master? I don't see any of your changes in the master branch and the feature does not appear to be available.

true! I was wrong! ... can someone merge it?

@mitsol mitsol reopened this Feb 24, 2021
@Slogo
Copy link

Slogo commented May 5, 2021

@jquense Is there something else needed to be done to get this Pull Request reviewed or committed?

@devmocionsoft
Copy link

Nice feature @georgebuciuman @mitsol It's possible for the conflicts to be solved Could I help with that?

@mitsol
Copy link
Author

mitsol commented Jan 5, 2022

I corrected the error when resizing a multi-resource event. Should work now!

@mitsol mitsol closed this Jan 5, 2022
@mitsol
Copy link
Author

mitsol commented Jan 5, 2022

Should work now as expected, please check.

@mitsol mitsol reopened this Jan 5, 2022
@jimhlad
Copy link

jimhlad commented Mar 11, 2022

Just wondering if there are any updates on this?

This is a really useful feature.

@murga96
Copy link

murga96 commented Mar 11, 2022

Why this PR is not commited to the master branch?? Please resolve the conflicts that must be resolved @mitsol or @jquense i don't know. This is a useful feature. Thanks in advantage.

@mitsol
Copy link
Author

mitsol commented Mar 12, 2022

Sorry guys, don't know why this won't be merged 🤷‍♂️

@jimhlad
Copy link

jimhlad commented Mar 14, 2022

@mitsol Thanks for fixing the conflicts.

@jquense @georgebuciuman Just wondering if there's any timeline we can expect for this to get merged in? Or anything else that needs to be done first?

@cutterbl
Copy link
Collaborator

@mitsol The new docs site went live yesterday, and all examples were moved into storybook. If you can integrate changes from master, and move your examples into a story with documentation (plus any other documentation updates needed), I'll review everything for inclusion.

@jimhlad
Copy link

jimhlad commented Apr 6, 2022

I'm looking into reconciling @mitsol 's changes with these updates.

May need a second pair of eyes on it though from someone more familiar with this package. Will link to the new PR once it's ready for review.

@mitsol
Copy link
Author

mitsol commented Apr 6, 2022

@jimhlad thanks a lot! Unfortunately i'm very busy at the moment, but everything I changed in the code I have already stated here:

#1649 (comment)

So should not be a big deal to change! I recently had a look with the new storybook documentation, but it needs more effort for me to adapt my changes for this new documentation.

@jimhlad jimhlad mentioned this pull request Apr 6, 2022
@jimhlad
Copy link

jimhlad commented Apr 6, 2022

@mitsol No problem.

Just opened a PR here with the proposed changes: #2165 @cutterbl

@cutterbl
Copy link
Collaborator

cutterbl commented Feb 9, 2023

Closing this PR in favor of #2165

@cutterbl cutterbl closed this Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple resources per event
8 participants