-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DnD support for custom DropWrapper components (dayWrapper and dateCellWrapper) #843
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
import React from 'react' | ||
import { action } from '@storybook/react' | ||
|
||
const customComponents = { | ||
dateCellWrapper: dateCellWrapperProps => { | ||
// Show 'click me' text in arbitrary places by using the range prop | ||
const hasAlert = dateCellWrapperProps.range | ||
? dateCellWrapperProps.range.some(date => { | ||
return date.getDate() % 12 === 0 | ||
}) | ||
: false | ||
|
||
const style = { | ||
display: 'flex', | ||
flex: 1, | ||
borderLeft: '1px solid #DDD', | ||
backgroundColor: hasAlert ? '#f5f5dc' : '#fff', | ||
} | ||
return ( | ||
<div style={style}> | ||
{hasAlert && ( | ||
<a onClick={action('custom dateCellWrapper component clicked')}> | ||
Click me | ||
</a> | ||
)} | ||
{dateCellWrapperProps.children} | ||
</div> | ||
) | ||
}, | ||
dayWrapper: dayWrapperProps => { | ||
// Show different styles at arbitrary time | ||
const hasCustomInfo = dayWrapperProps.value | ||
? dayWrapperProps.value.getHours() === 4 | ||
: false | ||
const style = { | ||
display: 'flex', | ||
flex: 1, | ||
backgroundColor: hasCustomInfo ? '#f5f5dc' : '#fff', | ||
} | ||
return ( | ||
<div style={style}> | ||
{hasCustomInfo && 'Custom Day Wrapper'} | ||
{dayWrapperProps.children} | ||
</div> | ||
) | ||
}, | ||
} | ||
|
||
export default customComponents |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ehahn9 I think it was you who did this initial implementation. Did you try implementing custom
EventWrapper
support?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the ping... Indeed I took a look at it but wimped out due to lack of time. This was on my wish list (*), so thanks for working on it! Our app doesn't require it, so I probably won't have time to review your excellent PR, tho. Anyone else?
(*) my other two hot buttons were per-event draggability and much better handling to the click geometry for dnd (right now the drag tracking is truly funky because it isn't based on the mousedown location.. others had spent time on the initial DnD implementation but we all gave up...)