fix(schema): Don't overwrite spec values with undefined (#1160)

jquense · Dec 12, 2020 · 207aea7 · 207aea7
1 parent e785e1a
commit 207aea7
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/schema.ts b/src/schema.ts
@@ -229,7 +229,14 @@ export default abstract class BaseSchema<
     let base = this;
     let combined = schema.clone();
 
-    const mergedSpec = { ...base.spec, ...combined.spec };
+    const baseSpec = { ...base.spec };
+    // only overwrite with spec values which are not undefined
+    const mergedSpec = Object.keys(combined.spec).reduce((accum, key) => {
+      if (combined.spec[key] !== undefined){
+        accum[key] = combined.spec[key]
+      }
+      return accum;
+    }, baseSpec)
 
     // if (combined.spec.nullable === UNSET)
     //   mergedSpec.nullable = base.spec.nullable;