fix(schema): Don't override spec values with undefined #1160

jquense · Dec 12, 2020 · e7150b9 · e7150b9
1 parent e785e1a
commit e7150b9
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/schema.ts b/src/schema.ts
@@ -229,7 +229,14 @@ export default abstract class BaseSchema<
  let base = this;
  let combined = schema.clone();
 
- const mergedSpec = { ...base.spec, ...combined.spec };
+ const baseSpec = { ...base.spec };
+ // only override with spec values which are not undefine
+ const mergedSpec = Object.keys(combined.spec).reduce((accum, key) => {
+ if (combined.spec[key] !== undefined){
+ accum[key] = combined.spec[key]
+ }
+ return accum;
+ }, baseSpec)
 
  // if (combined.spec.nullable === UNSET)
  // mergedSpec.nullable = base.spec.nullable;