-
Notifications
You must be signed in to change notification settings - Fork 159
Conversation
(44% branch coverage! Woo!) |
"karma-safari-launcher": "~0.1.1", | ||
"karma-script-launcher": "*", | ||
"mocha": "*" | ||
"grunt-git-authors": "^3.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't intern be listed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It totally was there the whole time and I didn’t force push a replacement commit to the branch to make it show up on line 12. Ahem. 😊
@csnover Now that intern is there I can run the tests except it fails with 0 tests.
|
Seems like there are some legit PEP failures in IE. Tests! CI! yay! |
@arschmitz You’ll need to add browserstack username and access key to your environment (BROWSERSTACK_USERNAME and BROWSERSTACK_ACCESS_KEY) to run the CI. Otherwise you can load http://path/to/intern/client.html?config=tests/intern in any browser, or you can start ChromeDriver and then run |
sudo: false | ||
language: node_js | ||
node_js: | ||
- "0.10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This already seems like outdated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not latest, but certainly not outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know but why not to directly include the latest one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it work? Does it do what we need it to do? Great. Don’t fix what isn’t broken. :)
@scottgonzalez You want to land this or is there something more that needs to be done? |
Refs #153