Skip to content
This repository has been archived by the owner on Feb 11, 2021. It is now read-only.

Update tests to use Intern #167

Closed
wants to merge 5 commits into from
Closed

Update tests to use Intern #167

wants to merge 5 commits into from

Conversation

csnover
Copy link
Contributor

@csnover csnover commented Mar 4, 2015

Refs #153

@csnover
Copy link
Contributor Author

csnover commented Mar 4, 2015

(44% branch coverage! Woo!)

"karma-safari-launcher": "~0.1.1",
"karma-script-launcher": "*",
"mocha": "*"
"grunt-git-authors": "^3.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't intern be listed here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It totally was there the whole time and I didn’t force push a replacement commit to the branch to make it show up on line 12. Ahem. 😊

@arschmitz
Copy link
Contributor

@csnover Now that intern is there I can run the tests except it fails with 0 tests.
Do I need to set up anything else to be able to run the tests?

Running "jshint:all" (jshint) task
>> 3 files lint free.
tests/intern
Tunnel: BrowserStackLocal v3.5

Total: Pending
Passed: 0  Failed: 0  Skipped: 0
Warning:  Use --force to continue.

Aborted due to warnings.

@csnover
Copy link
Contributor Author

csnover commented Mar 5, 2015

Seems like there are some legit PEP failures in IE. Tests! CI! yay!

@csnover
Copy link
Contributor Author

csnover commented Mar 5, 2015

@arschmitz You’ll need to add browserstack username and access key to your environment (BROWSERSTACK_USERNAME and BROWSERSTACK_ACCESS_KEY) to run the CI. Otherwise you can load http://path/to/intern/client.html?config=tests/intern in any browser, or you can start ChromeDriver and then run grunt test.

sudo: false
language: node_js
node_js:
- "0.10"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This already seems like outdated?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not latest, but certainly not outdated.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know but why not to directly include the latest one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work? Does it do what we need it to do? Great. Don’t fix what isn’t broken. :)

@csnover
Copy link
Contributor Author

csnover commented Mar 8, 2015

@scottgonzalez You want to land this or is there something more that needs to be done?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants