This repository has been archived by the owner on Feb 11, 2021. It is now read-only.
Package: Explicitly list dist/ in files to include it when publishing #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jzaefferer this would preclude other projects from using the individual files and force use of the built version. There has been talk of hammer.js using individual parts of pep ( like the touch-action handling ) |
|
I can add "src" to the list. Do we also want Anything else? |
|
I'd like to do a release as soon as this lands so we can get people using it. |
|
We should probably include |
The entry in .gitignore tells npm to also ignore the dist/ folder, adding it to files overrides that. It also excludes everything else, so we add some more useful files explicitly. Fixes jquery-archive#223
jzaefferer
force-pushed
the
package-files
branch
from
49b3618 to
b2739c8
Compare
|
Updated. Added source files and the |
|
What is the status on this issue? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #223
The
dist/folder is listed in.gitignore, which npm applies fornpm-publish. Adding afilesarray topackage.jsonoverrides that. It also removes everything else except LICENSE.txt, README.md and package.json, which should be fine.Tested with
npm install @jzaefferer/pepjs@0.3.3-pre