Docs: data attribute reference

[MauriceG]

I don't know who had the idea for and who did it, but
http://jquerymobile.com/test/docs/api/data-attributes.html
is great!
Thank you!

[toddparker]

I think pretty much everyone deserves credit for it since I've been asked a million times. Finally decided to sit down last night and just bang it out. Was easier than I thought.

[MauriceG]

Good job, Mr. Parker. Like usual 👍

[agcolom]

@toddparker Hi, I did update this file this morning (about 12h ago) but it did not generate an issue number, so I'm not sure you saw that...

[toddparker]

Hmm...no didn't see it. Did it come up as a pull request? Don't see one...

[agcolom]

I did a fork from master.... and then did press the button to submit the changes... but it didn't seem to have come up as a pull request (I may have missed the correct button??) All I got was the message:

     agcolom pushed to patch-1 at agcolom/jquery-mobile about 12 hours ago

    3869d00   closed  tags in all tables 

The link is agcolom@3869d00

[toddparker]

Hmmm. Not sure, but that is a good catch. Too tired last night and I copied and pasted the same mistake over and over...

[agcolom]

Sorry for chasing you on this one, but when I saw your tweet announcing the page, I thought it was better to make the changes quickly :-)

Any idea what I did wrong for not getting the pull request?

And @MauriceG is right, this page is a great addition. Well done the team :-)

[toddparker]

I'm not sure. Instead I copied your code in and committed myself with credit to you.

[toddparker]

3a32031

[agcolom]

Thank you :-)

I've also noticed that your 1st line of text below the element for which you are describing the data-attribute sometimes ends with a full stop (.) and sometimes omits it. I think it'd be best to have some consistency, there... If you tell me what you prefer, I'm more than happy to change it tomorrow morning (and I can check whether I am able to create a pull request!!!).

[toddparker]

Yeah, I noticed that. Probably better without. You can always browse to that page in the code here on github, click the edit button and modify the code directly. This will create a pull request. Great for content edits.

[MauriceG]

Hi Anne CET is calling ;-)
Are you ready editing the docs data attribute reference?
I see some other issues.
best wishes

[agcolom]

Hi Maurice :-) I did yesterday... I've just done some minor punctuation on header just now... If you want me to change more, I'm happy to do it, just let me know, but I have to go and take my daughter to her rehearsal (for the UK final school choir competition :-)), so will be away for a about 2h now...

[MauriceG]

Hi Anne!
I hope your daughters competition was a success!!

The issues i see:
Some code tags are not closed at the right point: data-role required instead of data-role required

The link of Fieldcontainer links to the footer page http://jquerymobile.com/test/docs/toolbars/docs-footers.html.
May the forms basic page at http://jquerymobile.com/test/docs/forms/docs-forms.html is a better place, cause there the fieldcontainers are explained.

The Header link links to a non-existent page http://jquerymobile.com/pages/toolbars/docs-headers.html
has to be http://jquerymobile.com/test/docs/toolbars/docs-headers.html

The Select link links to the slider-page at http://jquerymobile.com/test/docs/forms/slider/
which has to be the select page at http://jquerymobile.com/test/docs/forms/selects/

So far, that's it.
Hope to read from you soon.
Best wishes to GMT

[agcolom]

Hi Maurice :-)

Well done with all your findings :-) I'll do that today definitely.
The competition is on 20th Nov, but they have intensive rehearsals until then... fingers crossed :-)

best wishes,

Anne

[agcolom]

Hi Todd, in the data attribute reference page, you have "Fieldcontainer", but in the page http://jquerymobile.com/test/docs/forms/docs-forms.html that describes it, you have "Field container". Which term should be used? (I'll update the page accordingly :-) )

Have a good weekend everyone :-)

[toddparker]

Let's go with the version with spaces: field container.

.................................. . . . .
Todd Parker
Partner, Filament Group Inc.
102 South Street #3 Boston, MA 02111
todd@filamentgroup.com // 617.953.1617

On Nov 5, 2011, at 9:59 AM, "Anne-Gaelle Colom" reply@reply.github.com wrote:

Hi Todd, in the data attribute reference page, you have "Fieldcontainer", but in the page http://jquerymobile.com/test/docs/forms/docs-forms.html that describes it, you have "Field container". Which term should be used? (I'll update the page accordingly :-) )

Have a good weekend everyone :-)

---

Reply to this email directly or view it on GitHub:
#2935 (comment)

[agcolom]

Thanks, all done :-)