Esc (Escape key) should close dialogs

[deanrad]

To comply with the defacto convention ...

[eddiemonge]

This really only applies to desktops since mobile devices don't normally have the esc key. Because of that, I think its unneeded complexity because then it also asks, "what about click outside the dialog?"

[deanrad]

Good point. And what about click outside the dialog? User-configurable
setting on launching the dialog ?

On Fri, Nov 18, 2011 at 3:42 PM, Eddie Monge Jr.
reply@reply.github.com
wrote:

This really only applies to desktops since mobile devices don't normally have the esc key. Because of that, I think its unneeded complexity because then it also asks, "what about click outside the dialog?"

---

Reply to this email directly or view it on GitHub:
#3107 (comment)

[toddparker]

I think both are good ideas. Could you please link this up to the feature request wiki page and we'll re-open once we decide to add this feature?

[deanrad]

Done - thanks for letting me know what to do !

On Sun, Nov 20, 2011 at 10:00 PM, Todd Parker
reply@reply.github.com
wrote:

I think both are good ideas. Could you please link this up to the feature request wiki page and we'll re-open once we decide to add this feature?

---

Reply to this email directly or view it on GitHub:
#3107 (comment)