Fullscreen mode not working correctly on click

[cfjedimaster]

View the full screen demo, http://jquerymobile.com/demos/1.1.0-rc.1/docs/toolbars/bars-fullscreen.html, and note header/footer. Click to dismiss. Note that they animate away, but then return w/o text.

[adammessinger]

I noticed the same issue and created a simple test case on jsbin.

Note that when you're scrolled to the middle of the page the toolbars disappear and stay gone. They only come back empty when you're at the top or bottom.

[johnbender]

@scottjehl

Any chance you could take a look at this one, I was able to reproduce in chrome.

[scottjehl]

Looks like commit 71506f9 introduced the bug.

I can confirm that by undoing that change, and adding width: 100%; back in for the .ui-header, .ui-footer rule fixes this issue, so I'm guessing we just need to add it back, but perhaps scoped to fixed toolbars this time, since it's only needed there.

@Wilto - was there a bug related to that commit, or a particular conflict within our own code that made it necessary? If it was only related to external customizations where a developer needed to add left or right padding of their own, I'm wondering if that's the sort of thing where we should say, "if you need to add padding to the toolbar itself, adjust its width accordingly"…?

After this, I'll push a commit to fix this by bringing the width back for fixed toolbars only, and if any conflicts resurface as a result, we should probably figure out a plan to address them differently.

In testing, this not only fixes this issue, but seems to prevent blinks in Chrome during toolbar toggles (a nice unintentional bonus :) ).

On Mar 6, 2012, at 6:19 AM, John Bender wrote:

@scottjehl

Any chance you could take a look at this one, I was able to reproduce in chrome.h

---

Reply to this email directly or view it on GitHub:
#3678 (comment)