-
Notifications
You must be signed in to change notification settings - Fork 2.4k
UpdatePagePadding() and ui-page-header{ padding-top:2.5em; } #4412
Comments
@scottjehl - Should we still have those rules in the css now we have updatePagePadding?
If you set updatePagePadding to false these padding rules still apply. Is that the way we want it? |
Hmm. Well, as I'd said on the other issue, the option was about how often padding is updated, not whether it's set at all up-front. That said, the em value here should match the height of the header, or as close as we can get it, before JS manages it. If it needs an update to match the current default height, go for it. I'd still suggest using em units though, if we can. |
All clear (see also my comment on #4223). I will look into the default height - see if I can make it more consistent between browsers. Then I will update those padding rules. Issue with em units is the 1px border top and bottom, but will try to stick to those. |
…age with fixed toolbars.
After upgrading my app to 1.1.1, it seems like the flickering is still happening to my footer. I tried tweaking the padding-top padding-bottom with various value, there doesn't seem to be any changes at all to this flickering behaviour (ie. the 1-2px gap doesn't widen or shrink). In fact, it seems like the jquery mobile code is dynamically setting those padding anyway. I don't see how these css are doing anything in the case of fixed header/footers. Is this fix suppose to remedy the problem of the flickering fixed footer on page changes? Or have I misinterpreted this issue? |
I think you misunderstood what this issue was about.
Do you mind reporting your issue in a comment on issue #4259 which looks similar/related? |
For fixed headers, the call to UpdatePagePadding() causes page content to shift downward by 5px. This is due to the ui-page-header in structure being set to 2.5em ( or 16 x 2.5 = 40px ). Normally, jQM headers are 45px in height.
Setting ui-page-header-fixed to 45px ( or whatever your actual header height size is ) fixes this issue.
The text was updated successfully, but these errors were encountered: