-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Persistent navbar broken on scroll, Chrome for android #4663
Comments
So after some debugging, it seems that touch events start bubbling from the data-role=navbar element when scrolled down, normally it should be span->span->a->li->ul->div. |
Is this a duplicate of #3973? |
My issue is that the buttons don't work at all when you are scrolled down. This issue is more urgent, but the solution may be common to both. I can replicate #3973 with http://jquerymobile.com/demos/1.1.0/docs/toolbars/footer-persist-b.html but not with http://jquerymobile.com/test/docs/toolbars/footer-persist-c.html meanwhile, my issue stands on both versions. |
If it helps, the best workaround I've found is to remove the data-role=navbar attribute. It removes the nice styling, but at least it works. |
Works on 4.1 (default browser == chrome). We'll need a 4.0.1 device to test with. |
Hum, forgot to scroll or tried the info button only?... try this https://www.youtube.com/watch?v=P6Aj6bPeqvk&feature=youtube_gdata_player |
I can confirm that this does NOT work in 4.1. I'm running a Galaxy Nexus running 4.1.1 and Reyncor's test case did not work while in Chrome. My Galaxy Nexus has both the stock browser and Chrome. It works in the stock browser and does not work in Chrome. |
@Reyncor @daniel-sabourin I can reproduce with latest chrome on 4.1. I'll take a look. |
First attempt at a fix here in both master and 1.1-stable: You can test it with http://jquerymobile.com/branches/1.1-stable/js/ as your include. Please re-open if this doesn't address the issue. Thanks! |
I have found that this css workarounds the issue:
Maybe this will give you a clue to identify the problem on the deeper level. |
That would be much much nicer to use than the js hack I have in place. @Reyncor @daniel-sabourin Can you confirm that the above works for you as well? |
I can confirm that this addresses the issue. I'll probably let @uGoMobi take over from here. |
I can also confirm that this fixes the issue. Thanks @mmavko @johnbender @Reyncor |
Do we have to revert the initial changes made by @johnbender ? |
@staabm - if the CSS fix alone works, then yes. We're testing now but if you can test this and report back, we'd appreciate it. |
Sorry , but i have no android device |
I just tested master with @johnbender's commit reverted and the persistent toolbar items are clickable if the page is scrolled. Confirmed on 4.0.4 Default browser and Chrome and 4.1 Default (Chrome). @johnbender - This JS code can be reverted: |
Perfect, thanks to you guys! |
Hi All, This fix seems to have broken the layout of a navbar and a list combined on android 2.3.x when list text is too long to display. issue #4958
I have also seen @uGoMobi's clearfix suggestion of #5008 which fixes #4958 so perhaps we just need to implement that instead. R. |
…l, Chrome for android. Thanks @mmavko 👍
…in navbars Fixes jquery-archive#4663" This reverts commit b668b60.
To reproduce on Chrome for android (not beta):
non of them work.
It works perfectly on the android browser. With the imminent release of the Nexus 7, this is an issue that I cannot over look.
The text was updated successfully, but these errors were encountered: