Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Ajax and "base" tag #3273

Closed
wants to merge 10 commits into from
Closed

Ajax and "base" tag #3273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1e94a90
Ajax didnt work with $.support.dynamicBaseTag. Fixed.
jguyomard Dec 15, 2011
95b1705
Merge remote branch 'upstream/master'
jguyomard Dec 15, 2011
18602ba
When an original base tag is defined in HTML, $.support.dynamicBaseTa…
Dec 17, 2011
2543a0d
Merge branch 'master' of github.com:jguyomard/jquery-mobile
jguyomard Dec 22, 2011
b4c3e3d
getClosestBaseURL works now with ajax link when an original base tag …
jguyomard Dec 22, 2011
5219bbb
Merge remote branch 'upstream/master'
jguyomard Jan 20, 2012
d5c8107
don't change base url when a page is loaded by ajax
jguyomard Jan 20, 2012
c1b2f8d
now, a href works when an original base tag is defined in HTML
jguyomard Jan 20, 2012
3917830
ajax even if target top
jguyomard Jan 20, 2012
f9e5cce
data-prefetch on link tag
jguyomard Jan 20, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions js/jquery.mobile.navigation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -761,7 +761,7 @@ define( [
}

if ( base ) {
base.set( fileUrl );
//base.set( fileUrl );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the whole branch a no-op. If that's the intention maybe just remove it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not mistaken, that line is necessary to make sure that images within the page load properly. The problem here is that I think the base should be set to the fileUrl, or in the case where the page we just loaded contains a base tag, it should be set to that base tag path.

}

//workaround to allow scripts to execute when included in page divs
Expand Down Expand Up @@ -1140,7 +1140,7 @@ define( [
var url = $( ele ).closest( ".ui-page" ).jqmData( "url" ),
base = documentBase.hrefNoHash;

if ( !url || !path.isPath( url ) ) {
if ( !url || !path.isPath( url ) || || $.support.dynamicBaseTag ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you've got a double || here for some reason.

url = base;
}

Expand Down Expand Up @@ -1294,7 +1294,7 @@ define( [
}

// Should we handle this link, or let the browser deal with it?
var useDefaultUrlHandling = $link.is( "[rel='external']" ) || $link.is( ":jqmData(ajax='false')" ) || $link.is( "[target]" ),
var useDefaultUrlHandling = $link.is( "[rel='external']" ) || $link.is( ":jqmData(ajax='false')" ) || ( $link.is( "[target]" ) && !$link.is( "[target='_top']" ) ),

// Some embedded browsers, like the web view in Phone Gap, allow cross-domain XHR
// requests if the document doing the request was loaded via the file:// protocol.
Expand Down Expand Up @@ -1332,7 +1332,7 @@ define( [
//prefetch pages when anchors with data-prefetch are encountered
$( document ).delegate( ".ui-page", "pageshow.prefetch", function() {
var urls = [];
$( this ).find( "a:jqmData(prefetch)" ).each(function(){
$( this ).find( "a:jqmData(prefetch), link:jqmData(prefetch)" ).each(function(){
var $link = $(this),
url = $link.attr( "href" );

Expand Down
2 changes: 1 addition & 1 deletion js/jquery.mobile.support.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ function baseTagTest() {
if ( !base.length ) {
base = fauxEle = $( "<base>", { "href": fauxBase }).appendTo( "head" );
} else {
href = base.attr( "href" );
href = fauxEle = base.attr( "href" );
}

link = $( "<a href='testurl' />" ).prependTo( fakeBody );
Expand Down