Listview: Added option for the default list icon

[jasondscott]

No description provided.

[jaspermdegroot]

hi @jasondscott !

@MauriceG and I already had a nice discussion about making it possible to set a default icon for listviews. See #4582.

I think we should keep things simple for users and not add new options if not really necessary. So I suggest to stick to one option "icon" with the following possibilities:

default = "arrow-r"

1. [global] override the default for all listviews by using the $.mobile object
2. [UL/OL] override the default or global with data-icon on a listview OR with the option icon if that listview is created programmatically
3. [LI] override any of the above for a list item with data-icon on that specific list item

This could be done with the following additions / changes:

$.widget( "mobile.listview", $.mobile.widget, {
    options: {
        icon: "arrow-r",
    },


    refresh: function( create ) {
        var ...,
            listIcon = $list.jqmData( "icon" ) || o.icon,


            if ( a.length && !isDivider ) {
                    var itemIcon = item.jqmData( "icon" );   /* replaces: icon = item.jqmData( "icon" ); */

                    if ( a.length > 1 ) {
                        icon = false;
                    } else {
                        icon = itemIcon || listIcon;
                    }

                    item.buttonMarkup({
                        icon: icon,
                    });

[toddparker]

Thanks for the PR @jasondscott. Been hashing this out in IRC and I agree that the best approach would to re-use the data-icon attribute and just allow it to be set at the UL/OL level as the default for that instance. If you set a data-icon attribute on the LIs, that would override the icon set ont he UL/OL. I think this is what @uGoMobi was suggesting in #2, but wanted to confirm.

[jaspermdegroot]

Actually I was suggesting that in # 3 :)

I modified my previous comment to clarify on which 3 levels the user can set the icon option.

[MauriceG]

Hi @uGoMobi !

With the code above, it will not be possible to disable the icon at LI-level.

With my first PR for this feature it will ;-)

Maurice

[jaspermdegroot]

@MauriceG

Yes you are right. Just noticed that while testing my code. @jasondscott is working on this now.

[MauriceG]

Oh cool, thanks.

[jasondscott]

@toddparker @uGoMobi Can I pull this into master?

[toddparker]

I think I'd rather wait for a week since this is a new feature and we're at RC. As soon as 1.2 final is tagged, then yes. Looking forward to this addition.

[jaspermdegroot]

@jasondscott

Nice!

+1 for merging after 1.2 is out. If we land this in 1.2.1 let's not forget to pick in the 1.2-stable branch :)