Button markup corners can be string #5241
Conversation
…bl, br, top, left, right, bottom as well
…ead of setting corner classes manually -- Fixes #3635
…( "option", { ... }) and not via .buttonMarkup({ ... })
ghost
assigned 
|
Implications:
|
|
Briefly: |
|
I guess we could special-case the corner radii of buttons inside controlgroups from CSS, to coincide with the ui-corner-* values and then I can change controlgroup back so that it adds ui-corner-all to the outer container, rather than ui-btn-corner-all, and the shadows and border radii will work as before. |
|
Yeah I was just going to ask about the corner radius. It looks odd to me but that doesn't mean it's wrong. |
|
This change will affect a lot of widgets - grouped checks, radios, etc. We can't special case radii because these are themable CSS properties. We need to clarify our shadow classes since we have two: in ThemeRoller, we call these "group" and "button" so we should be applying the group class here. |
…ui-corner-* or anything else for ui-btn-corner-*
…e corners rather than button-style corners
|
OK, with the new cornerstyle option the group corner style is once again being applied to controlgroup widgets. |
|
BTW: This also fixes #3496 when controlgroup's |
|
Here's a fixed version of the fiddle from #3496 using this branch: http://jsfiddle.net/JwWpX/19/ |
| //>>excludeEnd("jqmBuildExclude"); | ||
| (function( $, undefined ) { | ||
|
|
||
| function flipClasses( els, flCorners ) { |
There was a problem hiding this comment.
Any reason this can't be on the widget? (nitpick)
…stion by johnbender
… to new location of widget
…recreate it, but to call its refresh() method - let the unit tests reflect that
…e(), because all children will be invisible, since the page itself is invisible during enhance
Button markup corners can be string -- Fixes #3496
This branch contains the implementation of the controlgroup widget, which is a roadmap item. It also fixes a problem that occurs when calling buttonMarup() on a button that is a member of the controlgroup (#3635).