Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

ISSUE#5534 - Fix pixel density on android swipe event #7431

Closed
wants to merge 1 commit into from

Conversation

TNT-RoX
Copy link

@TNT-RoX TNT-RoX commented May 27, 2014

Fixes swipe events for all pixel densities.

Fixes swipe events for all pixel densities.
@jaspermdegroot
Copy link
Contributor

@TNT-RoX

Thanks for the PR. Can you please sign the CLA. After that we can look into it.

@TNT-RoX
Copy link
Author

TNT-RoX commented May 27, 2014

Done

On 2014/05/27 3:20 PM, "Jasper de Groot" notifications@github.com wrote:

@TNT-RoX https://github.com/TNT-RoX

Thanks for the PR. Can you please sign the CLA
http://contribute.jquery.org/CLA/ . After that we can look into it.


Reply to this email directly or view it on GitHub
#7431 (comment) .

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 6365153 on TNT-RoX:patch-1 into 039c0b6 on jquery:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 6365153 on TNT-RoX:patch-1 into 039c0b6 on jquery:master.

@TNT-RoX
Copy link
Author

TNT-RoX commented May 29, 2014

Fix is for bug #5534

@TNT-RoX TNT-RoX changed the title Fix pixel density on android swipe event ISSUE#5534 - Fix pixel density on android swipe event May 29, 2014
@jaspermdegroot jaspermdegroot added this to the 1.5.0 milestone Jun 5, 2014
@arschmitz
Copy link
Contributor

@TNT-RoX Sorry this is so old but the name and email on the cla need to match whats in your git config and must be your real name not a screen name.

@TNT-RoX
Copy link
Author

TNT-RoX commented Jan 5, 2015

@arschmitz done!

@gabrielschulhof
Copy link

@TNT-RoX looking at the second line of the patch, it looks like it still bears your nickname, rather than your real name. Please change your git configuration and then re-commit. In bash, you can do something like this:

git config user.name "<Your Real Name Goes Here>"
git checkout . # This discards any changes you may have in your working tree
git checkout patch-1
git reset HEAD~1
git commit -a -m $'Events: Fix pixel density on android swipe event\n\nFixes gh-5534\nCloses gh-7431'
git push -f origin patch-1

@arschmitz arschmitz closed this in c299573 May 28, 2015
kapilgarg1996 pushed a commit to kapilgarg1996/jquery-mobile that referenced this pull request Jun 27, 2015
Fixes swipe events for all pixel densities.
This is a partial fix for some swipe related issues.

Ref jquery-archivegh-5534
closes jquery-archivegh-7431
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants