Skip to content
This repository has been archived by the owner on Feb 11, 2021. It is now read-only.

pepjs npm package is unusable #223

Closed
WestonThayer opened this issue Sep 30, 2015 · 3 comments
Closed

pepjs npm package is unusable #223

WestonThayer opened this issue Sep 30, 2015 · 3 comments
Milestone

Comments

@WestonThayer
Copy link

https://www.npmjs.com/package/pepjs

The package seems to just be a clone of this git repo. If I wanted to use pepjs in my application, I would either have to:

  1. Build pepjs as part of my build, or
  2. Configure something like browserify to understand ES6 import and directly reference pointerevents.js

It would be much more helpful if the pepjs npm package simply contained a copy of https://code.jquery.com/pep/0.3.0/pep.js. It's CommonJS compatible, so it can be easily incorporated without having to use option 1 or 2.

I'd be happy to submit a pull request fixing this for package.json, but wanted to check here first to ensure that I'm not off-base with this issue.

@scottgonzalez
Copy link
Contributor

That package is supposed to contain the dist directory (see the tag). I'm not sure why that isn't included in the npm install.

The main field has already been updated to point to the built file (see 19122a3).

Other than figuring out why the dist directory isn't included, is there anything else that needs to happen?

@jzaefferer
Copy link
Contributor

See #224 for a fix.

@WestonThayer
Copy link
Author

Fantastic, thank you!

jzaefferer added a commit to jzaefferer/PEP that referenced this issue Oct 2, 2015
The entry in .gitignore tells npm to also ignore the dist/ folder,
adding it to files overrides that. It also excludes everything else,
so we add some more useful files explicitly.

Fixes jquery-archive#223
WestonThayer pushed a commit to WestonThayer/framer-pep that referenced this issue Oct 7, 2015
Includes a local version of pepjs.js 0.3.0 because of
jquery-archive/PEP#223. Will remove and reference the
npm package when that's fixed.

Haven't tested with Framer Studio yet, only framer-cli.
@scottgonzalez scottgonzalez added this to the 0.4.0 milestone Nov 4, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants