Skip to content

Datepicker: Add documentation for onUpdateDatepicker callback option #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

patrick-vandy
Copy link
Contributor

Update datepicker's documentation for changes made in jquery/jquery-ui#1912

@mgol
Copy link
Member

mgol commented May 20, 2021

The change looks good, thanks!

@fnagel are you familiar with how the docs for a specific version are generated? I wonder if updating the main branch wouldn't update the 1.12 docs. If that's the case then we need to prepare a 1.13 setup before merging this, let's keep this in mind.

@fnagel
Copy link
Member

fnagel commented May 21, 2021

@mgol No, I'm not familiar, but you're right, we should keep this in mind. Did you create a checklist somewhere?

@mgol
Copy link
Member

mgol commented Jun 18, 2021

I was thinking about doing the API setup for 1.13 before merging this but we can't as the main URLs like https://api.jqueryui.com/addClass/ need to resolve to 1.12 as long as 1.13 is not released yet. This is good to merge then, we just need to not tag commits on main before the 1.13 release; if any 1.12 docs need updates, we can create tags on the 1-12 branch.

I'll merge the PR.

@mgol mgol merged commit 59f595a into jquery:main Jun 18, 2021
@mgol
Copy link
Member

mgol commented Jun 18, 2021

Landed, thanks for the docs update, @patrick-vandy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants