Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downstream test: include redeyed. #1378

Closed
wants to merge 1 commit into from

Conversation

ariya
Copy link
Contributor

@ariya ariya commented Nov 14, 2015

Closes #1377

@codecov-io
Copy link

Current coverage is 100.00%

Merging #1378 into master will not affect coverage as of e0edc06

@@            master   #1378   diff @@
======================================
  Files            1       1       
  Stmts         3081    3081       
  Branches       582     582       
  Methods          0       0       
======================================
  Hit           3081    3081       
  Partial          0       0       
  Missed           0       0       

Review entire Coverage Diff as of e0edc06

Powered by Codecov. Updated on successful CI builds.

@mikesherov
Copy link
Member

👍 congrats on the pickup ;-)

@ariya
Copy link
Contributor Author

ariya commented Nov 14, 2015

Unfortunately we can't verify this yet because CircleCI failed to complete the tests of JSCS. This seems to happen quite often with JSCS. I'm going to experiment with the change of the order so that JSCS becomes the last one.

@mikesherov
Copy link
Member

I wonder why JSCS fails so often. Ping @hzoo

@ariya ariya closed this in 6f18c06 Nov 14, 2015
@hzoo
Copy link

hzoo commented Nov 14, 2015

Doesn't look like you can see any error messages? It just checks out master and then (END)the build was canceled? Or maybe I don't understand that output

@ariya ariya deleted the downstream-redeyed branch November 16, 2015 19:56
@ariya
Copy link
Contributor Author

ariya commented Nov 20, 2015

@hzoo Better tracking it at #1247.

ariya added a commit to ariya/esprima that referenced this pull request Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants