Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track and collect the comments without the callback. #1382

Closed
wants to merge 2 commits into from
Closed

Track and collect the comments without the callback. #1382

wants to merge 2 commits into from

Conversation

ariya
Copy link
Contributor

@ariya ariya commented Nov 15, 2015

Fixes #1381

@codecov-io
Copy link

Current coverage is 100.00%

Merging #1382 into master will not affect coverage as of 7fa4752

@@            master   #1382   diff @@
======================================
  Files            1       1       
  Stmts         3036    3060    +24
  Branches       577     585     +8
  Methods          0       0       
======================================
+ Hit           3036    3060    +24
  Partial          0       0       
  Missed           0       0

Review entire Coverage Diff as of 7fa4752

Powered by Codecov. Updated on successful CI builds.

mikesherov
mikesherov reviewed Nov 15, 2015
View reviewed changes
test/utils/evaluate-testcase.js
esprima.tokenize(code, { tolerant: true, comment: false, loc: false, range: false });
esprima.tokenize(code, { tolerant: true, comment: false, loc: false, range: true });
esprima.tokenize(code, { tolerant: true, comment: false, loc: true, range: false });
esprima.tokenize(code, { tolerant: true, comment: false, loc: false, range: true });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loc: true here or it's redundant of two lines above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@mikesherov
Copy link
Member

Should we pull JSCS out until I or @hzoo can figure out what's going on there?

@mikesherov
Copy link
Member

Aside from the test nits, 👍 really great work here.

@ariya
Copy link
Contributor Author

ariya commented Nov 15, 2015

Should we pull JSCS out until I or @hzoo can figure out what's going on there?

Good idea, I reopened #1247 to track that.

@ariya ariya closed this in e72c392 Nov 15, 2015
@ariya ariya deleted the scan-comments branch November 16, 2015 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ariya @codecov-io @mikesherov @jquerybot