Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for-await-of #2031

Closed
wants to merge 5 commits into from
Closed

support for-await-of #2031

wants to merge 5 commits into from

Conversation

Meir017
Copy link
Contributor

@Meir017 Meir017 commented Aug 25, 2020

closes #1990

  • should work for generators
esprima.parseScript('async function *g() { for await (let y of []) {} }')
  • should throw an error if it's not used within an async function
esprima.parseScript('function f() { for await (let i of []) {} }')

@jsf-clabot
Copy link

jsf-clabot commented Aug 25, 2020

CLA assistant check
All committers have signed the CLA.

@Meir017 Meir017 marked this pull request as ready for review August 25, 2020 14:26
@Meir017
Copy link
Contributor Author

Meir017 commented Aug 25, 2020

@ariya, please review

@Meir017
Copy link
Contributor Author

Meir017 commented Sep 18, 2020

esprima doesn't seem to support yet parsing of async generators async function * .
I think this is out of scope of this feature and should be done in a separate PR

@ariya ariya closed this in 4f52923 Sep 27, 2020
@Meir017 Meir017 deleted the es2018/for-await-of branch September 28, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

ES2018 Feature: Async Iteration (for-await-of)
2 participants