Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin a version of grunt-wordpress to 2.1.4 #92

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

mgol
Copy link
Member

@mgol mgol commented Nov 8, 2023

grunt-wordpress updates gilded-wordpress in patch releases. However, our infra requires strict matching of the gilded-wordpress version in the GW_VERSION variable set in gilded-wordpress.php. Let's pin the version to avoid breaking changes from subdependencies updates.

I'll publish the next release once this lands; perhaps 3.2.1.

@mgol mgol requested review from Krinkle and timmywil November 8, 2023 17:55
@mgol mgol changed the title Ping a version of grunt-wordpress to 2.1.4 Pin a version of grunt-wordpress to 2.1.4 Nov 8, 2023
`grunt-wordpress` updates `gilded-wordpress` in patch releases. However,
our infra requires strict matching of the `gilded-wordpress` version
in the `GW_VERSION` variable set in `gilded-wordpress.php`. Let's pin
the version to avoid breaking changes from subdependencies updates.
Copy link
Member

@Krinkle Krinkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm preparing a commit that merges grunt-wordpress into this repo, and another commit that updates a few more dependencies.

@Krinkle Krinkle merged commit 8290d06 into jquery:main Nov 8, 2023
@mgol
Copy link
Member Author

mgol commented Nov 8, 2023

@Krinkle OK, I'll hold off with publishing then.

@mgol mgol deleted the fixes branch November 8, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants