Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jquery migrate jQuery.isArray #220

Closed
kumarmj opened this issue Aug 14, 2016 · 1 comment
Closed

jquery migrate jQuery.isArray #220

kumarmj opened this issue Aug 14, 2016 · 1 comment
Assignees
Milestone

Comments

@kumarmj
Copy link

kumarmj commented Aug 14, 2016

Issue raised based on checklist of jquery/jquery#2961

@dmethvin dmethvin added this to the 3.1.0 milestone Dec 5, 2016
dmethvin added a commit to dmethvin/jquery-migrate that referenced this issue Dec 23, 2016
@dmethvin
Copy link
Member

dmethvin commented Jan 29, 2017

I had to revert the commit and reopen this, I should have realized that the previous 3.x versions still have this used internally and thus throw spurious errors. This is the same problem that would manifest in #156 and #246 if they were landed now.

We can either wait until jQuery Migrate 4.0 to land all these or add a version check and only give the warnings on later jQuery 3.x versions. Even with that, it makes the refactoring of the methods in core the critical path.

@dmethvin dmethvin reopened this Jan 29, 2017
@dmethvin dmethvin self-assigned this Mar 22, 2018
dmethvin added a commit to dmethvin/jquery-migrate that referenced this issue Jun 9, 2019
dmethvin added a commit to dmethvin/jquery-migrate that referenced this issue Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants