Skip to content

Script error for "jquery-patch.js" #2107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mihaelams1 opened this issue Aug 3, 2022 · 1 comment · Fixed by #2109
Closed

Script error for "jquery-patch.js" #2107

mihaelams1 opened this issue Aug 3, 2022 · 1 comment · Fixed by #2109
Assignees
@mgol
Labels
Bug Comp: Core
Milestone
1.13.3

Comments

@mihaelams1
Copy link

I know core.js is deprecated, but until then if one is using individual files as opposed to the bundled version they might encounter an issue in which requirejs can't find jquery-patch:
image
This is due to the fact that in core.js it is referenced as "jquery-patch.js" as opposed to just "jquery-patch":

image
@mgol mgol added this to the 1.13.3 milestone Aug 10, 2022
@mgol mgol self-assigned this Aug 10, 2022
mgol added a commit to mgol/jquery-ui that referenced this issue Aug 10, 2022
@mgol
Core: Fix dependencies in ui/core.js
22439e6 
The `jquery-patch` reference was included with the `.js` extension which is
not allowed in AMD.

Fixes jquerygh-2107
@mgol mgol mentioned this issue Aug 10, 2022
Merged
@mgol
Copy link
Member

mgol commented Aug 10, 2022

Thanks for the report! Fix at #2109.

mgol added a commit that referenced this issue Aug 18, 2022
@mgol
Core: Fix dependencies in ui/core.js
5fa0db4 
The `jquery-patch` reference was included with the `.js` extension which is
not allowed in AMD.

Fixes gh-2107
Closes gh-2109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgol mgol

Labels
Bug Comp: Core
Milestone
1.13.3
Development

Successfully merging a pull request may close this issue.

Core: Fix dependencies in ui/core.js mgol/jquery-ui
2 participants
@mihaelams1 @mgol