Effects Rewrite #1017

mikesherov · 2013-06-26T13:25:20Z

Tasks

Testing

re-enable createWrapper test since IE7 is no more.
demos in IE8+
unit tests pass in IE8+
visual tests are looking good in IE8+
get tests passing in "modern" browsers
visual tests in "modern" browsers.
demos in "modern" browsers.

Follow up

http://bugs.jqueryui.com/ticket/10606 Not a regression introduced by this PR (aka already broken): In IE8 the toggleClass demo doesn't animate the height decrease (first click), while the height increase is animated (second click).
http://bugs.jqueryui.com/ticket/10605 Other than transfer and size, we could simplify all effects by having the common done() function remove the placeholder (if it exists), and do the final hide based on the mode. There are a few effects which use if ( !show ) instead of if ( hide ) to determine if .hide() should be called, but those can probably all be normalized since this would only affect people explicitly passing a mode of effect when they really mean hide, which probably isn't happening. We'd need to have .createPlaceholder() store a reference to the placeholder to make this work, but that's simple.
file bug with core: ( subpixel jump on FF shake visual test )
file bug with chrome: (chrome "auto" reports "0px" for clip ) https://code.google.com/p/chromium/issues/detail?id=412921
file bugs with ui: deprecate backCompat'ed method, remove backcompat'ed methods
http://bugs.jqueryui.com/ticket/10599 http://bugs.jqueryui.com/ticket/10600

jzaefferer · 2013-06-26T13:33:57Z

Travis/grunt sezs: "FFFFFFFFF". At least there's no "UUUUUUUUUU".

mikesherov · 2013-06-26T14:26:39Z

Yup, tests are broken. They test the wrong thing. I'll fix, but wanted to get some human eyes on it.

gnarf · 2013-10-16T17:05:55Z

👍 seems sane to me.

mikesherov · 2014-02-14T14:52:41Z

@scottgonzalez @jzaefferer ping. The last bits here are just verifying that visual and units are working in IE ( they all work in Safari, Opera, Chrome, FF), and also animating the placeholder for blind and fold.

Can you both review the code please?

jzaefferer · 2014-02-18T18:26:04Z

Even when ignoring white space changes, I have a hard time reviewing this, since I know so little about the existing code. @mikesherov how about a Skype session where we review the code together? You could walk me (and Scott, if available) through the changes.

scottgonzalez · 2014-02-18T18:41:25Z

If @mikesherov's availability is still low, I can walk you through the code some time this week. I have a decent understanding of the existing code and I've done a walk through of this code at least once with @mikesherov (though it was a long time ago).

scottgonzalez · 2014-02-20T17:09:55Z

tests/unit/effects/effects_core.js

@@ -75,20 +75,6 @@ test( "removeClass", function() {
 	equal( "", element[ 0 ].className );
 });

-
-/* TODO: Disabled - Can't figure out why this is failing in IE 6/7


Determine if we can enable this now that we don't support IE 6/7.

Well, it's testing a deprecated function anyway, but I'll see if I can enable it.

Looked into enabling it, and it seemed like it passes, but I'm still removing the test because I'd have to remove it anyway in the future.

scottgonzalez · 2014-02-20T18:16:19Z

We need to look at what happens if you load an old effect definition with the new core. Does it break default modes? Anything else?

scottgonzalez · 2014-02-21T13:42:57Z

Initial findings from /demos/effect/default.html:

Fold is broken in IE8 (vertical blind is good, but then regresses before the horizontal blind).
Highlight is broken (no effect).
Puff is broken (expands to bottom right instead of growing from center; doesn't fade).
Pulsate is broken (no effect).
Scale is broken (implodes to top right instead of center).
Slide is broken (no effect).

mikesherov · 2014-02-21T23:05:14Z

Hmmm. Any other good test files to use, @scottgonzalez? I was using the visual test suite, but apparently that isn't nearly good enough.

scottgonzalez · 2014-02-24T21:04:25Z

Other than the actual test files, I think the default effect demo is the only other file to use.

jzaefferer · 2014-04-24T08:59:05Z

demos/effect/show.html, Scale is broken, throws Uncaught TypeError: Cannot call method 'call' of undefined in effect-scale.js:70.

jzaefferer · 2014-04-24T17:43:32Z

Not a regression introduced by this PR (aka already broken): In IE8 the toggleClass demo doesn't animate the height decrease (first click), while the height increase is animated (second click).

mikesherov · 2014-09-12T20:20:40Z

Not a regression introduced by this PR (aka already broken): In IE8 the toggleClass demo doesn't animate the height decrease (first click), while the height increase is animated (second click).

I'm not going to fix this in the effects rewrite as I don't touch any of the toggleClass stuff. Filed a bug instead: http://bugs.jqueryui.com/ticket/10606

jzaefferer · 2014-10-29T16:56:10Z

@mikesherov what's the status here? There's two open issues on the task list above, are you working on those? Do you need help with testing?

mikesherov · 2014-11-15T20:08:08Z

@scottgonzalez @jzaefferer ready for rereview!

scottgonzalez · 2014-11-24T17:37:09Z

ui/effect.js

+				// that turn to inline block based on content (like img)
+				display: /^(inline|ruby)/.test( element.css( "display" ) ) ? "inline-block" : "block",
+				visibility: "hidden",
+				// margins need to be set to account for margin collapse


blank line, capitalization

scottgonzalez · 2014-11-24T17:51:48Z

I still need to do some actual testing in the browser, but I finished looking through the changes.

@mikesherov Can you file an api.jqueryui.com issue for all the API changes and new methods? We can fill in the actual details later, but it'd be good to have a list of what we need to document.

scottgonzalez · 2014-11-25T14:30:53Z

The height of the main element in the effect demos is now too small because of the font-size changes in master.

scottgonzalez · 2014-11-25T14:33:57Z

Scale show doesn't animate, but showing via toggle does.

mikesherov · 2014-11-26T22:08:55Z

@scottgonzalez the punchline was that the supplied params in the demo weren't sane. The code was fine :-\

mikesherov · 2014-11-26T22:17:33Z

@jzaefferer @scottgonzalez ping for rereview

mikesherov · 2014-11-26T22:19:42Z

@jzaefferer note that the semantics of .show( "size", to: { width:x, height:y } ) has changed to match .toggle, such that there is no longer a magic "from zero to to behavior" for show. show behaves exactly as a .toggle that ultimately called a show would do: that is, use the to as the starting point, and end on the non-hidden size of the element.

scottgonzalez · 2014-11-26T23:14:11Z

Looks good. Just need to address the element size (see previous comment).

mikesherov · 2014-11-28T19:50:24Z

@scottgonzalez addressed the element size. Should be good for final review. /cc @jzaefferer

mikesherov · 2014-11-28T20:10:59Z

@scottgonzalez not sure what I need to document. Basically all the methods I deprecated were already not documented to begin with. Is the intent that for the effects rewrite we will document all of the helper methods I created on $.effects like $.effects.createPlaceholder and $.fn.cssClip? I'm not sure what needs to be documented. Would appreciate some insight here.

scottgonzalez · 2014-12-01T13:45:34Z

We should document anything that an effect author would need. I'm not too worried about documenting stuff for old versions. Right now I just want a list of the method signatures in an issue on api.jqueryui.com so we make sure it gets done before the release.

mikesherov · 2014-12-01T17:27:24Z

@scottgonzalez done: jquery/api.jqueryui.com#242

scottgonzalez · 2014-12-01T17:55:29Z

Perfect. Thanks.

jzaefferer · 2014-12-10T15:26:27Z

ui/effect.js

@@ -950,113 +1131,109 @@ $.extend( $.effects, {
 	// this should be a little more flexible in the future to handle a string & hash


Is this comment still correct? It looks like only the formatting changed, but I doubt that we're going to change this method in the future.

I left it in because I didn't write the original :-)

jzaefferer · 2014-12-10T15:39:36Z

Tested locally and in BrowserStack on various browsers, using the visual test pages. Reviewed a few individual effects and effect.js in detail. Didn't find anything interesting except for those comments. Not sure if any of those even need to change, so this is likely good to land.

scottgonzalez reviewed Feb 20, 2014
View reviewed changes

scottgonzalez added this to the 1.12 milestone Sep 2, 2014

mikesherov force-pushed the clip branch from 23f04a1 to c2a1ca8 Compare September 3, 2014 19:38

mikesherov force-pushed the clip branch from c2a1ca8 to b0ae7f3 Compare September 12, 2014 16:43

mikesherov force-pushed the clip branch from 0ca0cc5 to 6ae27b7 Compare November 15, 2014 19:37

Effects Rewrite

fea61ce

scottgonzalez reviewed Nov 24, 2014
View reviewed changes

mikesherov added 2 commits November 25, 2014 18:27

Effects Rewrite: Style Changes From Code Review

40e9a82

Effects Rewrite: consolidate scaledDimensions

1cd8fb8

Effects Rewrite: Style fixes

4855481

mikesherov added 3 commits November 26, 2014 18:43

Effects Rewrite: Rename el and o to element and options

e9b02fe

Effects Rewrite: Fix style nits in size effect

2f39707

Effects Rewrite: Fix demo sizes to account for new font sizes

2a37345

jzaefferer reviewed Dec 10, 2014
View reviewed changes

mikesherov closed this in b6bec79 Dec 10, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Effects Rewrite #1017

Effects Rewrite #1017

mikesherov commented Jun 26, 2013

jzaefferer commented Jun 26, 2013

mikesherov commented Jun 26, 2013

gnarf commented Oct 16, 2013

mikesherov commented Feb 14, 2014

jzaefferer commented Feb 18, 2014

scottgonzalez commented Feb 18, 2014

scottgonzalez Feb 20, 2014

mikesherov Feb 20, 2014

mikesherov Sep 13, 2014

scottgonzalez commented Feb 20, 2014

scottgonzalez commented Feb 21, 2014

mikesherov commented Feb 21, 2014

scottgonzalez commented Feb 24, 2014

jzaefferer commented Apr 24, 2014

jzaefferer commented Apr 24, 2014

mikesherov commented Sep 12, 2014

jzaefferer commented Oct 29, 2014

mikesherov commented Nov 15, 2014

scottgonzalez Nov 24, 2014

scottgonzalez commented Nov 24, 2014

scottgonzalez commented Nov 25, 2014

scottgonzalez commented Nov 25, 2014

mikesherov commented Nov 26, 2014

mikesherov commented Nov 26, 2014

mikesherov commented Nov 26, 2014

scottgonzalez commented Nov 26, 2014

mikesherov commented Nov 28, 2014

mikesherov commented Nov 28, 2014

scottgonzalez commented Dec 1, 2014

mikesherov commented Dec 1, 2014

scottgonzalez commented Dec 1, 2014

jzaefferer Dec 10, 2014

mikesherov Dec 10, 2014

jzaefferer commented Dec 10, 2014

		@@ -950,113 +1131,109 @@ $.extend( $.effects, {
		// this should be a little more flexible in the future to handle a string & hash

Effects Rewrite #1017

Effects Rewrite #1017

Conversation

mikesherov commented Jun 26, 2013

Tasks

Discuss

Testing

Follow up

jzaefferer commented Jun 26, 2013

mikesherov commented Jun 26, 2013

gnarf commented Oct 16, 2013

mikesherov commented Feb 14, 2014

jzaefferer commented Feb 18, 2014

scottgonzalez commented Feb 18, 2014

scottgonzalez Feb 20, 2014

Choose a reason for hiding this comment

mikesherov Feb 20, 2014

Choose a reason for hiding this comment

mikesherov Sep 13, 2014

Choose a reason for hiding this comment

scottgonzalez commented Feb 20, 2014

scottgonzalez commented Feb 21, 2014

mikesherov commented Feb 21, 2014

scottgonzalez commented Feb 24, 2014

jzaefferer commented Apr 24, 2014

jzaefferer commented Apr 24, 2014

mikesherov commented Sep 12, 2014

jzaefferer commented Oct 29, 2014

mikesherov commented Nov 15, 2014

scottgonzalez Nov 24, 2014

Choose a reason for hiding this comment

scottgonzalez commented Nov 24, 2014

scottgonzalez commented Nov 25, 2014

scottgonzalez commented Nov 25, 2014

mikesherov commented Nov 26, 2014

mikesherov commented Nov 26, 2014

mikesherov commented Nov 26, 2014

scottgonzalez commented Nov 26, 2014

mikesherov commented Nov 28, 2014

mikesherov commented Nov 28, 2014

scottgonzalez commented Dec 1, 2014

mikesherov commented Dec 1, 2014

scottgonzalez commented Dec 1, 2014

jzaefferer Dec 10, 2014

Choose a reason for hiding this comment

mikesherov Dec 10, 2014

Choose a reason for hiding this comment

jzaefferer commented Dec 10, 2014