Button: Escape label option as text #1632
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Button labels have always been HTML and this is sort of a requirement since you can initialize a button that already has a label which contains HTML. A change like this would require discussion, proper ticket, upgrade guide, etc. |
|
Note that the bug that was actually reported is legit. The |
|
Okay, we can discuss that in the meeting today. If we stick with html labels, we need to add a test for that. |
|
Closing this, will create a PR to add tests for the current behaviour instead, and patch dialog to escape the |
jzaefferer
added a commit
that referenced
this pull request
Oct 28, 2015
jzaefferer
added a commit
that referenced
this pull request
Oct 28, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes jquery/api.jqueryui.com#281