Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme fixes #1753

Closed
wants to merge 2 commits into from
Closed

Theme fixes #1753

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e9dc84
Theme: Switch icon background to use bgColorContent
arschmitz Sep 29, 2016
eeae88a
Theme: Replace missing definition for default icons
arschmitz Sep 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions themes/base/theme.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ a.ui-button:active,
.ui-icon-background,
.ui-state-active .ui-icon-background {
border: #003eff/*{borderColorActive}*/;
background-color: #ffffff/*{fcActive}*/;
background-color: #ffffff/*{bgColorContent}*/;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we pairing the content background with the active border? Why is this not using the active background?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The active background does not look good at all in the majority of themes. We can switch the border color to match though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I think it makes sense for these to match. Though it's a shame the active colors don't work here.

}
.ui-state-active a,
.ui-state-active a:link,
Expand Down Expand Up @@ -204,8 +204,7 @@ a.ui-button:active,
.ui-state-hover .ui-icon,
.ui-state-focus .ui-icon,
.ui-button:hover .ui-icon,
.ui-button:focus .ui-icon,
.ui-state-default .ui-icon {
.ui-button:focus .ui-icon {
background-image: url("images/ui-icons_555555_256x240.png")/*{iconsHover}*/;
}
.ui-state-active .ui-icon,
Expand All @@ -220,7 +219,8 @@ a.ui-button:active,
.ui-state-error-text .ui-icon {
background-image: url("images/ui-icons_cc0000_256x240.png")/*{iconsError}*/;
}
.ui-button .ui-icon {
.ui-button .ui-icon,
.ui-state-default .ui-icon {
background-image: url("images/ui-icons_777777_256x240.png")/*{iconsDefault}*/;
}

Expand Down