Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme: Don't load the image sprite for ui-icon-blank #1874

Closed
wants to merge 1 commit into from

Conversation

scottgonzalez
Copy link
Member

Fixes #15193

@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@fnagel fnagel self-assigned this Dec 10, 2019
@fnagel
Copy link
Member

fnagel commented Dec 10, 2019

Hey @scottgonzalez, thanks for you PR Looks good to me.

Any idea why you're no longer in the CLA list? Would you mind adding your email again? That would help with your other PR (#1840) too.

I really hope you and your family is doing well!

@scottgonzalez
Copy link
Member Author

Any idea why you're no longer in the CLA list?

Yes, because the foundation's administration and legal teams are a joke and they threw out years of valid signatures.

Would you mind adding your email again? That would help with your other PR (#1840) too.

I do mind. I do not like the new CLA and the foundation's legal counsel has a very different interpretation of the new CLA than I do. As such, I will not sign it. However, there is nothing that should stop you from merging any of my PRs. See globalizejs/globalize#703 for some more background.

I really hope you and your family is doing well!

We are, thanks! I hope you're doing well too.

@fnagel
Copy link
Member

fnagel commented Jan 2, 2020

@scottgonzalez Thanks for the response. Sadly, I'm not that sure if I'm able to merge this without valid CLA.

@kborchers @StevenAyr Sorry to bother, but am I able to merge this or not? Do we really need to throw this bugfix away? Please take a look at #1840 too.

@kborchers
Copy link
Member

@fnagel I am not in a position to make that call anymore and likely would have deferred to legal's advise even if I were. I am adding @brianwarner to the thread to get his take and he can get legal advise if necessary. Sorry I can't be more helpful but hopefully Brian can get this resolved for you quickly.

@fnagel
Copy link
Member

fnagel commented Mar 23, 2020

@brianwarner Any news on this one?

@melloware
Copy link

I would also really like to see this merged as its a good performance improvement.

@fnagel
Copy link
Member

fnagel commented Jul 23, 2020

Closed in favor of #1934

@fnagel fnagel closed this Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants