Resources: Moved builder script & css from jquery-wp-content to jquerymobile.com #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to go |
|
The component is jquerymobile.com, not Resources. I can land this once jquerymobile.com is deployed with the new paths. |
|
Tagged v1.4.2 on jquery/jquerymobile.com, it's deployed. @scottgonzalez you can land this whenever. |
|
Updated commit message to fit in 72 characters. |
Krinkle
added a commit
that referenced
this pull request
Apr 18, 2024
Follows-up 9131422, which did most of the legwork already by importing theme code for blog.jquery.com, which I did (mostly) in a way that is shared and blended into the jquery base theme so that there is very little to import from the jqueryui and jquerymobile blog themes, yet producing an identical rendering for them. From https://github.com/jquery/blog.jquery.com-theme/tree/6710984735eb980cc9845b17f98aa0db8eac09e6/jqueryui.com and https://github.com/jquery/blog.jquery.com-theme/tree/6710984735eb980cc9845b17f98aa0db8eac09e6/jquerymobile.com blog/jqueryui.com -> themes/jqueryui.com blog/jquerymobile.com -> themes/jquerymobile.com * /category.php /index.php /style.css Redundant with inherited themes/jquery/category.php. Is identical apart from minor coding style differences. * /content.php Redundant with inherited themes/jquery/content.php. Slight differences regarding showing excerpts for non-first results on the home page, which has been intentionally changed in previous commits to jquery-wp-content, and blog still has the older version. Ignore in favour of what we have here. * /footer.php Same as destination themes/jqueryui.com/footer.php. * /single.php /sidebar.php These differ from the base theme in an important way, but are identical to the one for blog.jquery.com, which I previously imported into the base theme single-blogpost.php and sidebar-blogpost.php, so we only need stubs there, just like we did in themes/jquery.com/ before. * /functions.php - Hardcodes "jquery-ui" or "jquery-mobile" for body_class. We set this via the jquery_body_class option in sites.php instead. - Various dynamic body class entries. This is already covered by /plugins/jquery-filters.php, which we enable on all sites and will be enabled on the blog too when we switch it to use jquery-wp-content. Additionally, blog/jquerymobile.com/ had a builder.css and builder.js. They were copied to the blog when the blog originally forked off from jquery-wp-content, and were never used there. The copy in the original repo here has since been removed in bd3f0d61cdc98 as part of #272. Ref jquery/infrastructure-puppet#17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.