Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Make result update more efficient #215

Closed
jzaefferer opened this issue Jul 11, 2012 · 2 comments
Closed

Make result update more efficient #215

jzaefferer opened this issue Jul 11, 2012 · 2 comments
Assignees
Milestone

Comments

@jzaefferer
Copy link
Member

jzaefferer commented Jul 11, 2012

On big job pages the update is rather slow. As @Krinkle said in #213:

"It does create a document fragment, though, that should be made more efficient by only returning the table html from the server. That way we don't have to have .load() it and .find() the table in order to compare the innerHTML."

Should do that.

@scottgonzalez
Copy link
Member

We should just return HTML. There's no need to complicate it with JS templates.

@Krinkle Krinkle self-assigned this Jul 10, 2017
@Krinkle
Copy link
Member

Krinkle commented Jul 10, 2017

Resolved with:

  • 979693b job.js: Use $targetTable instead of querying the DOM again
  • aca1805 job.js should keep refreshing even when everything is complete and "reset" happens.
  • 86cb636 job.js: Add error handler to hide indicator and schedule next update

And today:

  • a569c99 Page: Implement partial response support for JobPage

@Krinkle Krinkle added this to the 1.1.0 milestone Jul 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants