Skip to content

Commit

Permalink
Use Kernel system exception handling
Browse files Browse the repository at this point in the history
system handles exceptions correctly as of ruby 2.7.

This pattern can be use wherever we rolled our own exception handling.
  • Loading branch information
jrafanie committed Sep 13, 2024
1 parent 4ce508e commit 81f76d9
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions lib/tasks/locale.rake
Original file line number Diff line number Diff line change
Expand Up @@ -312,10 +312,7 @@ namespace :locale do
Dir.mkdir(combined_dir, 0o700)
po_files.each do |locale, files|
files.each do |file|
unless system "msgfmt --check #{file}"
puts "Fatal error running 'msgfmt --check' on file: #{file}. Review the output above."
exit 1
end
system("msgfmt --check #{file}", :exception => true)
end

dir = File.join(combined_dir, locale)
Expand Down

0 comments on commit 81f76d9

Please sign in to comment.