Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and remove features from the UI #30

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

davejachimiak
Copy link

Adding features from the UI

In the case where RolloutUI is used in a system that eager loads enabled features for a user rather than asking whether a specific feature is enabled, developers can only create features through some sort of back-end mechanism like through the Rails console or a rake task.

This pull gives admins/developers the ability to add features directly from the Rollout UI, making it way easier to add features for such a system mentioned above.

Remove features from the UI

When a feature toggle is no longer necessary for a given feature, there is no way to clean up these features from the UI, let alone some back end mechanism.

This pull gives admins/developers the ability to remove features directly from the Rollout UI which will help keep our indexes clean.

This was referenced Jul 7, 2014
@bomatson
Copy link

+1 remove features! Very needed

@kbaum
Copy link

kbaum commented Aug 27, 2014

+1 remove features

@mwynholds
Copy link

+1 what do you think @jrallison can you merge this and give us 0.3.1 or 0.4?

@gingerlime
Copy link

+1. One thing I noticed however, is that rollout also stores a comma-separated list of features in feature:__features__. But doesn't look like RolloutUI is using.

In case it's helpful, I wrote a tiny helper to remove features from Rollout

module RolloutHelper                                                                                                                                                                                               
  def self.remove_feature(feature)                                                                                                                                                                                 
    features = redis.get('feature:__features__').split(',')                                                                                                                                                 
    features.delete(feature)                                                                                                                                                                                       
    redis.set('feature:__features__', features.join(','))                                                                                                                                                   
    redis.srem('features', feature)                                                                                                                                                                         
  end                                                                                                                                                                                                              
end     

@fredrik
Copy link

fredrik commented Mar 18, 2015

Let's merge this, @jrallison

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants