-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add and remove features from the UI #30
Open
davejachimiak
wants to merge
7
commits into
jrallison:master
Choose a base branch
from
davejachimiak:add_and_remove_features_in_ui
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add and remove features from the UI #30
davejachimiak
wants to merge
7
commits into
jrallison:master
from
davejachimiak:add_and_remove_features_in_ui
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: lib/rollout_ui/engine/app/controllers/rollout_ui/features_controller.rb lib/rollout_ui/engine/config/routes.rb spec/requests/engine/engine_spec.rb
This was referenced Jul 7, 2014
Closed
+1 remove features! Very needed |
+1 remove features |
+1 what do you think @jrallison can you merge this and give us 0.3.1 or 0.4? |
+1. One thing I noticed however, is that rollout also stores a comma-separated list of features in In case it's helpful, I wrote a tiny helper to remove features from Rollout module RolloutHelper
def self.remove_feature(feature)
features = redis.get('feature:__features__').split(',')
features.delete(feature)
redis.set('feature:__features__', features.join(','))
redis.srem('features', feature)
end
end |
Let's merge this, @jrallison |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding features from the UI
In the case where RolloutUI is used in a system that eager loads enabled features for a user rather than asking whether a specific feature is enabled, developers can only create features through some sort of back-end mechanism like through the Rails console or a rake task.
This pull gives admins/developers the ability to add features directly from the Rollout UI, making it way easier to add features for such a system mentioned above.
Remove features from the UI
When a feature toggle is no longer necessary for a given feature, there is no way to clean up these features from the UI, let alone some back end mechanism.
This pull gives admins/developers the ability to remove features directly from the Rollout UI which will help keep our indexes clean.