Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add session id to network requests #797

Merged
merged 1 commit into from
Dec 15, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ import com.jraska.github.client.AppVersion
import com.jraska.github.client.core.BuildConfig
import dagger.Module
import dagger.Provides
import dagger.multibindings.IntoSet
import okhttp3.Cache
import okhttp3.Interceptor
import okhttp3.OkHttpClient
import okhttp3.logging.HttpLoggingInterceptor
import okhttp3.logging.HttpLoggingInterceptor.Level
Expand Down Expand Up @@ -34,11 +36,11 @@ object HttpModule {
@Singleton
internal fun provideOkHttpClient(
context: Context,
appHeadersInterceptor: AppCommonHeadersInterceptor
interceptors: @JvmSuppressWildcards Set<Interceptor>
): OkHttpClient {
val builder = OkHttpClient.Builder()

builder.addInterceptor(appHeadersInterceptor)
interceptors.forEach { builder.addInterceptor(it) }

if (BuildConfig.DEBUG) {
val loggingInterceptor =
Expand All @@ -57,7 +59,8 @@ object HttpModule {

@Provides
@Singleton
internal fun appHeadersInterceptor(appVersion: AppVersion): AppCommonHeadersInterceptor {
@IntoSet
internal fun appHeadersInterceptor(appVersion: AppVersion): Interceptor {
return AppCommonHeadersInterceptor(appVersion)
}

Expand Down
2 changes: 2 additions & 0 deletions feature/identity/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,12 @@ dependencies {
implementation project(':feature:identity-api')

implementation 'org.threeten:threetenbp:1.5.1:no-tzdb'
implementation okHttp

kapt daggerAnnotationProcessor
implementation dagger

testImplementation 'junit:junit:4.13.2'
testImplementation 'org.assertj:assertj-core:3.23.1'
testImplementation okHttpMockWebServer
}
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
package com.jraska.github.client.identity

import com.jraska.github.client.identity.internal.AddSessionIdInterceptor
import com.jraska.github.client.identity.internal.AnonymousIdentity
import com.jraska.github.client.identity.internal.SessionIdProvider
import com.jraska.github.client.time.TimeProvider
import dagger.Module
import dagger.Provides
import dagger.multibindings.IntoSet
import okhttp3.Interceptor
import javax.inject.Singleton

@Module
Expand All @@ -23,5 +26,11 @@ object IdentityModule {
}

@Provides
internal fun identityProvider(implementation: IdentityProviderImpl): IdentityProvider = implementation
internal fun identityProvider(impl: IdentityProviderImpl): IdentityProvider = impl

@Provides
@IntoSet
internal fun addSessionIdInterceptor(identityProvider: IdentityProvider): Interceptor {
return AddSessionIdInterceptor(identityProvider)
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
package com.jraska.github.client.identity.internal

import com.jraska.github.client.identity.IdentityProvider
import okhttp3.Interceptor
import okhttp3.Response

class AddSessionIdInterceptor(
private val identityProvider: IdentityProvider
) : Interceptor {
override fun intercept(chain: Interceptor.Chain): Response {
val newRequest = chain.request()
.newBuilder()
.addHeader("Session-Id", identityProvider.session().id.toString())
.build()

return chain.proceed(newRequest)
}
}