Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed Violations #285

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blakepolidore
Copy link

@blakepolidore blakepolidore commented Oct 16, 2024

This is a potential solution to this issue. What I am hoping to achieve is to be able to pass in a map of modules and a list of their violated dependency modules and have the plugin accept this list of violations and not flag it as a violation.

Copy link
Owner

@jraska jraska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the PR efforts.

The allowed violations seem to do exactly the same as allowed with the difference of the second entry would be a list and not regex.

I won't accept this change, sorry, as it creates a very similar configuration behaving slightly differently and the same could be achieved by replacing:
"key" -> ["1", "2,", ... ,"N"] for "key -> 1", "key -> 2", ... , "key -> N" or by Regex - please see here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants