Body wrapper customization. Fix #280 #281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrblevin
requested changes
Nov 6, 2017
| @@ -758,6 +759,14 @@ | |||
| ;; * `markdown-xhtml-header-content' - additional content to include | |||
| ;; in the XHTML `<head>` block (default: `""`). | |||
| ;; | |||
| ;; * `markdown-xhtml-body-preamble' - additional content to include in the | |||
| ;; XHTML <body> block, before the output. This is useful if you'd like to | |||
| ;; wrap the Markdown output around extra elements (default: `""`')." | |||
| ;; | ||
| ;; * `markdown-xhtml-body-epilogue' - additional content to include in the | ||
| ;; XHTML <body> block, after the output. This is useful if you'd like to | ||
| ;; wrap the Markdown output around extra elements (default: `""`'). |
There was a problem hiding this comment.
Stray single quote (`) here also.
| @@ -7,6 +7,7 @@ | |||
| ;; Maintainer: Jason R. Blevins <jblevins@xbeta.org> | |||
| ;; Created: May 24, 2007 | |||
| ;; Version: 2.4-dev | |||
| ;; Package-Version: 20171031.1725 | |||
There was a problem hiding this comment.
Please remove this Package-Version header.
| @@ -7770,7 +7791,13 @@ Standalone XHTML output is identified by an occurrence of | |||
| (insert markdown-xhtml-header-content)) | |||
| (insert "\n</head>\n\n" | |||
| "<body>\n\n") | |||
| (when (> (length markdown-xhtml-body-preamble) 0) | |||
| (insert markdown-xhtml-body-preamble)) | |||
| (insert "\n") | |||
There was a problem hiding this comment.
It might be better to put this newline inside the when block, so that existing output for those who haven't customized this variable will be exactly the same.
| (goto-char (point-max)) | ||
| (insert "\n") |
There was a problem hiding this comment.
Same for this newline (see above).
|
Here is a sketch of a test that I started working on. I didn't test the test yet though, but hopefully if it doesn't work as is it can be a good starting point. (ert-deftest test-markdown-export/body-preamble ()
"Test `markdown-xhtml-body-preamble'."
(markdown-test-temp-file "export-test.md"
(let* ((str "<!-- body preamble test -->")
(markdown-xhtml-body-preamble str)
(ofile (markdown-export))
(obuffer (get-file-buffer ofile)))
(with-current-buffer obuffer
(goto-char (point-min))
(should (search-forward str)))
(kill-buffer obuffer)
(delete-file ofile)))) |
|
Ah I've completely forgotten about this PR. Thanks for fixing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the addition of a body preamble and epilogue to further customize the generated HTML.