Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend footnote insertion with text notes #586

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

iwahbe
Copy link

@iwahbe iwahbe commented Jan 15, 2021

Description

Allow insertion of footnotes tagged with text instead of numbers.

This behavior is controlled with a variable: markdown-footnote-default-type.
Because of the default value set, this is not a breaking change. Changing the customization or
wrapping the function markdown-insert-footnote allows this to be useful.

I also introduce a customization to recalculate markdown-footnote-counter on each insertion.
I mostly work on small files, and delete footnotes a lot. This makes life easier. Again, by default it
does not change behavior.

Related Issue

None I'm aware of.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have updated the documentation in the README.md file if necessary.
  • I have added an entry to CHANGES.md.
  • I have added tests to cover my changes.
  • All new and existing tests passed (using make test).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant