Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make markdown-mouse-follow-link work when nil #610

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adaerr
Copy link

@adaerr adaerr commented Apr 18, 2021

Hi,
This PR makes markdown-mode behave as intended when markdown-mouse-follow-link (introduced in commit 0fdbf89 as an answer to issue GH-290) is false: no link highlighting through mouse-face, and no link following. No guarantee as to the cleanliness or elegance of the hack, but an improvement over the preceding state. Also corrects a minor bug which prevented the variable from being customisable interactively.

In summary this commit

  1. corrects the variable type so it can be toggled in customize-mode
  2. defines markdown-mode-mouse-map to an empty map instead of just breaking it
  3. deactivates the mouse-face property attribution when no link
    following wanted.
    This provides the (presumably) intended behaviour when set to nil.

Thanks for markdown-mode!
cheers, Adrian

Description

Related Issue

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have updated the documentation in the README.md file if necessary.
  • I have added an entry to CHANGES.md.
  • I have added tests to cover my changes.
  • All new and existing tests passed (using make test).

This commit
1. corrects the variable type so it can be toggled in customize-mode
2. defines markdown-mode-mouse-map to an empty map instead of just breaking it
3. deactivates the mouse-face property attribution when no link
   following wanted.
This provides the (presumably) intended behaviour when set to nil.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant