-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Vim-Signify #93
Conversation
ce18fd7
to
6e3b9e1
Compare
Thanks for the PR! But jenkins is positive:
Please fix your commit, preferably with a |
6e3b9e1
to
f4f114d
Compare
Sorry about that.. It was a bad leftover from previous commit.. Now it should work. |
endif | ||
if ( g:magit_refresh_gutter == 1 || g:magit_refresh_gitgutter == 1) | ||
|
||
if ( exists("*gitgutter#process_buffer") ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You save a if statement at runtime, but the evaluation is done at plugin initialization. It means that if vimagit is loaded before gitgutter and/or vim-signify, exists("*gitgutter#process_buffer")
will be evaluated to false.
I do not like either the if
in the autocmd, but this is the only way to not be dependent on plugin loading order.
Please, only add vim signify support for this PR.
If you find a better way to check gitgutter/vim-signify presence, I'll be happy to merge :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.. That makes sense.
I'll cut this down to solving signify for now.
Aside from the if controversy, are you ok with changing the variable name?
Excellent! Could you please update the doc/vimagit.txt and README.md with the new Thanks again for the PR! |
Argh, I missed the jenkins complaint!
I'll do the doc update, just fix this for the merge. |
Sorry for taking long. This should be fixed now. |
Can we merge this? |
Hi Henry, I'm very sorry for the delay. I really don't have much time at the moment. It's a pity because you did two nice PRs. You're also the first one to propose PRs touching in the heart of vimagit. That's why I am so careful. The content of this PR is OK to me. I don't want to discourage you (I really should write some PR guideline). Could you:
For the first point, I want to test your feature one week or two before merging it to master. It is mandatory. For the second point, it is a nice to have for this commit. It will be mandatory for your next PRs. In a PR, I would prefer to not have:
Thanks for your effort! |
No problem! I'll address those points later this week, as I'm out on holidays. |
35f7366
to
e1e862c
Compare
@jreybert Done |
Thanks! |
As well as gitgutter, add support for vim-signify.