Is this better ?

jrfnl · Nov 30, 2024 · 52579f1 · 52579f1
1 parent 8e86aa4
commit 52579f1
Showing 1 changed file with 13 additions and 16 deletions.
diff --git a/scripts/BuildRequirementsCheckMatrix.php b/scripts/BuildRequirementsCheckMatrix.php
@@ -88,18 +88,15 @@ public function getBuilds()
      */
     private function getValidBuilds()
     {
-        $extensions = [
-            'default' => '',
-            'minimal' => 'none, tokenizer, xmlwriter, SimpleXML',
-        ];
+        $extensions = ['minimal' => 'none, tokenizer, xmlwriter, SimpleXML'];
 
         $builds = [];
-        foreach ($this->os as $os) {
+        foreach ($this->validPhp as $php) {
             foreach ($this->cmd as $cmd) {
-                foreach ($this->validPhp as $php) {
-                    foreach ($extensions as $name => $exts) {
+                foreach ($extensions as $name => $exts) {
+                    foreach ($this->os as $os) {
                         $builds[] = [
-                            'name'       => "exts: $name, expect: success",
+                            'name'       => ":heavy_check_mark: exts: $name",
                             'os'         => $os,
                             'cmd'        => $cmd,
                             'php'        => $php,
@@ -124,12 +121,12 @@ private function getInvalidPHPBuilds()
         $extensions = ['default' => ''];
 
         $builds = [];
-        foreach ($this->os as $os) {
+        foreach ($this->invalidPhp as $php) {
             foreach ($this->cmd as $cmd) {
-                foreach ($this->invalidPhp as $php) {
-                    foreach ($extensions as $exts) {
+                foreach ($extensions as $exts) {
+                    foreach ($this->os as $os) {
                         $builds[] = [
-                            'name'       => 'fail on PHP too low',
+                            'name'       => ':x: PHP too low',
                             'os'         => $os,
                             'cmd'        => $cmd,
                             'php'        => $php,
@@ -159,12 +156,12 @@ private function getMissingExtensionsBuilds()
         ];
 
         $builds = [];
-        foreach ($this->os as $os) {
+        foreach ($this->validPhp as $php) {
             foreach ($this->cmd as $cmd) {
-                foreach ($this->validPhp as $php) {
-                    foreach ($extensions as $name => $exts) {
+                foreach ($extensions as $name => $exts) {
+                    foreach ($this->os as $os) {
                         $builds[] = [
-                            'name'       => "fail on $name",
+                            'name'       => ":x: $name",
                             'os'         => $os,
                             'cmd'        => $cmd,
                             'php'        => $php,