This repository has been archived by the owner on Oct 5, 2018. It is now read-only.
Added split processing option #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 10, 2013 15:34
Detect when only_process is set but different on has_attached_file and process_in_background. In which case run foreground styles in normal hook, and allow the backgrounded job to handle the styles on process_in_background as normal.
jrgifford
pushed a commit
that referenced
this pull request
Jan 20, 2014
|
this is merged already, right? here: a898f49 |
ScotterC
pushed a commit
to ScotterC/delayed_paperclip
that referenced
this pull request
Feb 19, 2014
Fix for when attachment is set on a parent class (eg ActiveRecords STI) The only_process was nil which wasn't being checked against [] very well only_process now defaults to []
Merged
|
handled in #79 |
ScotterC
pushed a commit
to ScotterC/delayed_paperclip
that referenced
this pull request
Feb 19, 2014
Fix for when attachment is set on a parent class (eg ActiveRecords STI) The only_process was nil which wasn't being checked against [] very well only_process now defaults to []
ScotterC
pushed a commit
to ScotterC/delayed_paperclip
that referenced
this pull request
Feb 19, 2014
Fix for when attachment is set on a parent class (eg ActiveRecords STI) The only_process was nil which wasn't being checked against [] very well only_process now defaults to []
ScotterC
pushed a commit
to ScotterC/delayed_paperclip
that referenced
this pull request
Feb 19, 2014
Fix for when attachment is set on a parent class (eg ActiveRecords STI) The only_process was nil which wasn't being checked against [] very well only_process now defaults to []
ScotterC
pushed a commit
that referenced
this pull request
Feb 19, 2014
xaro
added a commit
to xaro/delayed_paperclip
that referenced
this pull request
May 3, 2014
* master_upstream: (43 commits) bump version to 2.7.1 Updating the Processing column bump version Merges in jrgifford#62 Testing Support for paperclip 4 Cleaned up Rake and Testing files fix default urs for split processing fix undefined method `[]' for nil:NilClass, Issue#66 Use ruby 2.0, p195. Added test for split_processing option and explanation in README Allow processing some styles in foreground, some in background Test to make sure tmp files are getting cleared Fix undefined method `[]' for nil:NilClass with Paperclip 3.5.2 Update resque links in README.textile Updated tests with new queue option Fixed failing tests Added support for setting delayed_job queue Update specs to accept unscoped find chain Fix process jobs for models with default_scope try to fix delayed_job version ... Conflicts: lib/delayed_paperclip.rb lib/delayed_paperclip/attachment.rb
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the option to process some styles in the foreground and some in the background, by setting :only_process on both has_attached_file and process_in_background.
The actual code changes are minimal and there's a test for the additional functionality.
The use case I have in mind is handling video - you want the thumbnail created immediately, but need to delay the video conversion because it'll take a while.