multi: add zstd support #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 15, 2024
Closed
guggero
approved these changes
Aug 16, 2024
| @@ -0,0 +1,7 @@ | |||
| module github.com/jrick/logrotate/rotator | |||
There was a problem hiding this comment.
Since the whole project on its own is already rather small, does it really make sense to turn this into its own Gomodule? IMO just the root one should be enough.
| @@ -0,0 +1,7 @@ | |||
| module github.com/jrick/logrotate | |||
|
|
|||
| go 1.22 | |||
There was a problem hiding this comment.
The github.com/klauspost/compress library only seems to require Go 1.20. Could keep this at the same level to remove the need for also specifying toolchain...
|
closing in favor of #3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZSTD is both faster and compresses at higher ratios than gzip, so it would be useful to have it as an option when rotating logs.
Further pro-ZSTD arguments here:
golang/go#62513